Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <1433950405.375893.291973049.101362CB@webmail.messagingengine.com>
References: <1433950405.375893.291973049.101362CB@webmail.messagingengine.com> <4954.1432838811@warthog.procyon.org.uk>
To: Colin Walters <walters@verbum.org>
Cc: dhowells@redhat.com, miklos@szeredi.hu, viro@ZenIV.linux.org.uk,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        linux-unionfs@vger.kernel.org
Subject: Re: [PATCH] overlayfs: Warn on copy up if a process has a R/O fd open to the lower file
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <17647.1433952771.1@warthog.procyon.org.uk>
Date: Wed, 10 Jun 2015 17:12:51 +0100
Message-ID: <17649.1433952771@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 726
Lines: 17

Colin Walters <walters@verbum.org> wrote:

> On Thu, May 28, 2015, at 02:46 PM, David Howells wrote:
> > Print a warning when overlayfs copies up a file if the process that
> > triggered the copy up has a R/O fd open to the lower file being copied up.
> 
> Why not an option to make it an error?  If one's goal is to use overlayfs
> without apps potentially corrupting data, better to fail fast.

That could be added.  Note that doing this isn't *necessarily* wrong though.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/