Message-ID: <1433953156.32331.4.camel@perches.com>
Subject: Re: [RFC][PATCH] printk: Fixup the nmi printk mess
From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
        jkosina@suse.cz, paulmck@linux.vnet.ibm.com, pmladek@suse.cz,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 10 Jun 2015 09:19:16 -0700
In-Reply-To: <20150610120242.1e33c752@gandalf.local.home>
References: <20150610125509.GO19282@twins.programming.kicks-ass.net>
	 <20150610120242.1e33c752@gandalf.local.home>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 778
Lines: 28

On Wed, 2015-06-10 at 12:02 -0400, Steven Rostedt wrote:

> BTW, the printk.c file is getting rather big.

No joke that.

> Can we make a
> kernel/printk/nmi.c file that does this work. We can add a local
> printk_common.h that can share the global data structures, and this
> would move most of the #ifdef out of the C files.

Yes please.

There are many things in printk that could be moved
into separate files.

The last time I tried this was before Kay's structured
printk logging stuff:

https://lkml.org/lkml/2012/10/24/748


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/