Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965320AbbFJREW (ORCPT ); Wed, 10 Jun 2015 13:04:22 -0400 Received: from mail-ig0-f169.google.com ([209.85.213.169]:33619 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964841AbbFJREM (ORCPT ); Wed, 10 Jun 2015 13:04:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433896397-16748-1-git-send-email-rajatja@google.com> Date: Wed, 10 Jun 2015 10:04:11 -0700 Message-ID: Subject: Re: [PATCH v2] [x86/kvm] emulate.c: Fix comppilation warning From: Rajat Jain To: Bandan Das Cc: Gleb Natapov , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Rajat Jain Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1881 Lines: 56 Hello Bandan, On Tue, Jun 9, 2015 at 6:17 PM, Bandan Das wrote: > Rajat Jain writes: > >> Fix the following warning: >> >> arch/x86/kvm/emulate.c: In function '__do_insn_fetch_bytes': >> arch/x86/kvm/emulate.c:814:47: warning: 'linear' may be used uninitialized in this function [-Wmaybe-uninitialized] >> arch/x86/kvm/emulate.c:793:16: note: 'linear' was declared here > > Is this recent gcc behavior ? If yes, please mention that in the commit > message. Sorry, I realized that I was using an internal version of gcc. I don't see the warning with gcc 4.8.2 that comes with ubuntu. So I guess we can ignore the patch then... Thanks, Rajat > > Please follow convention for the subject line and fix the typo - > "KVM: emulate: Fix compilation warning" > > Thanks, > Bandan > > >> Signed-off-by: Rajat Jain >> Signed-off-by: Rajat Jain >> --- >> v2: Fix the wrong email address. >> >> arch/x86/kvm/emulate.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c >> index 630bcb0..f06e0ca 100644 >> --- a/arch/x86/kvm/emulate.c >> +++ b/arch/x86/kvm/emulate.c >> @@ -790,7 +790,7 @@ static int __do_insn_fetch_bytes(struct x86_emulate_ctxt *ctxt, int op_size) >> { >> int rc; >> unsigned size, max_size; >> - unsigned long linear; >> + unsigned long linear = 0; >> int cur_size = ctxt->fetch.end - ctxt->fetch.data; >> struct segmented_address addr = { .seg = VCPU_SREG_CS, >> .ea = ctxt->eip + cur_size }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/