Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933780AbbFJRy7 (ORCPT ); Wed, 10 Jun 2015 13:54:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43569 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933673AbbFJRyv (ORCPT ); Wed, 10 Jun 2015 13:54:51 -0400 From: Jes Sorensen To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Julia Lawall , Larry Finger , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH 1/1 linux-next] staging: rtl8723au: use swap() in WMMOnAssocRsp23a() References: <1433953937-23987-1-git-send-email-fabf@skynet.be> Date: Wed, 10 Jun 2015 13:54:49 -0400 In-Reply-To: <1433953937-23987-1-git-send-email-fabf@skynet.be> (Fabian Frederick's message of "Wed, 10 Jun 2015 18:32:17 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1594 Lines: 51 Fabian Frederick writes: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick > --- > drivers/staging/rtl8723au/core/rtw_wlan_util.c | 12 +++--------- > 1 file changed, 3 insertions(+), 9 deletions(-) Please make sure you base your patches off the staging tree, not off linux-next. Jes > > diff --git a/drivers/staging/rtl8723au/core/rtw_wlan_util.c b/drivers/staging/rtl8723au/core/rtw_wlan_util.c > index 5280338..3c1315fc 100644 > --- a/drivers/staging/rtl8723au/core/rtw_wlan_util.c > +++ b/drivers/staging/rtl8723au/core/rtw_wlan_util.c > @@ -573,7 +573,7 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter) > inx[0] = 0; inx[1] = 1; inx[2] = 2; inx[3] = 3; > > if (pregpriv->wifi_spec == 1) { > - u32 j, tmp, change_inx = false; > + u32 j, change_inx = false; > > /* entry indx: 0->vo, 1->vi, 2->be, 3->bk. */ > for (i = 0; i < 4; i++) { > @@ -589,14 +589,8 @@ void WMMOnAssocRsp23a(struct rtw_adapter *padapter) > } > > if (change_inx) { > - tmp = edca[i]; > - edca[i] = edca[j]; > - edca[j] = tmp; > - > - tmp = inx[i]; > - inx[i] = inx[j]; > - inx[j] = tmp; > - > + swap(edca[i], edca[j]); > + swap(inx[i], inx[j]); > change_inx = false; > } > } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/