Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933029AbbFJSI7 (ORCPT ); Wed, 10 Jun 2015 14:08:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:56397 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754267AbbFJSIu (ORCPT ); Wed, 10 Jun 2015 14:08:50 -0400 Date: Wed, 10 Jun 2015 11:08:49 -0700 From: Andrew Morton To: Davidlohr Bueso Cc: Xiao Guangrong , Paolo Bonzini , Edward Cree , Bandan Das , gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization Message-Id: <20150610110849.c37b91940bcda177c93d09ff@linux-foundation.org> In-Reply-To: <1433959366.3165.87.camel@stgolabs.net> References: <556486F3.5020007@solarflare.com> <556487A6.2020804@redhat.com> <5565318D.1030309@linux.intel.com> <1433959366.3165.87.camel@stgolabs.net> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1667 Lines: 40 On Wed, 10 Jun 2015 11:02:46 -0700 Davidlohr Bueso wrote: > On Wed, 2015-05-27 at 10:53 +0800, Xiao Guangrong wrote: > > > > On 05/26/2015 10:48 PM, Paolo Bonzini wrote: > > > > > > > > > On 26/05/2015 16:45, Edward Cree wrote: > > >>>> This breaks older compilers that can't initialize anon structures. > > >>>> > > >>>> How old ? Even gcc 3.1 says you can use unnamed struct/union fields and > > >>>> 3.2 is the minimum version required to compile the kernel as mentioned > > >>>> in the README. > > >>>> > > >>>> We could simply just name the structure, but I doubt this is the > > >>>> only place in the kernel code where it's being used this way :) > > >> This appears to be GCC bug #10676, see > > >> Says it was fixed in 4.6, but I believe the kernel supports GCCs much older > > >> than that (back to 3.2). I personally hit it on 4.4.7, the version shipped > > >> with RHEL6.6. > > > > > > Yes, it will be fixed soon(ish). Probably before you can get rid of the > > > obnoxious disclaimer... :) > > > > It has been fixed by Andrew: > > > > From: Andrew Morton > > Subject: arch/x86/kvm/mmu.c: work around gcc-4.4.4 bug > > Folks, this fix is missing in both -tip and Linus' (4.1-rc7) tree. At > least I'm running into it. hm, yes, it's in linux-next so I dropped my copy. I'll send it in to Linus today. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/