Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965163AbbFJSR7 (ORCPT ); Wed, 10 Jun 2015 14:17:59 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47699 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964968AbbFJSRf (ORCPT ); Wed, 10 Jun 2015 14:17:35 -0400 Date: Wed, 10 Jun 2015 20:17:32 +0200 From: Pavel Machek To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros Message-ID: <20150610181732.GB2993@amd> References: <6b0f0a275e240eb4f6889eea8863875041f05bba.1433937132.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6b0f0a275e240eb4f6889eea8863875041f05bba.1433937132.git.jpoimboe@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 46 On Wed 2015-06-10 07:06:09, Josh Poimboeuf wrote: > Add the FP_SAVE and FP_RESTORE asm macros, which can be used to save and > restore the frame pointer. Add a changelog, which can be used to tell what changed. > Signed-off-by: Josh Poimboeuf > --- > arch/x86/include/asm/func.h | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > create mode 100644 arch/x86/include/asm/func.h > > diff --git a/arch/x86/include/asm/func.h b/arch/x86/include/asm/func.h > new file mode 100644 > index 0000000..4d62782 > --- /dev/null > +++ b/arch/x86/include/asm/func.h > @@ -0,0 +1,24 @@ > +#ifndef _ASM_X86_FUNC_H > +#define _ASM_X86_FUNC_H > + > +#include > +#include > + > +/* > + * These are frame pointer save and restore macros. They should be used by > + * every callable non-leaf asm function. > + */ > +.macro FP_SAVE name > + .if CONFIG_FRAME_POINTER > + push %_ASM_BP > + _ASM_MOV %_ASM_SP, %_ASM_BP > + .endif > +.endm Hmm. This will not compile when included into .c file. Should it have other extension than .h? (Or can the macros be done in different way? -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/