Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933774AbbFJSlw (ORCPT ); Wed, 10 Jun 2015 14:41:52 -0400 Received: from mga01.intel.com ([192.55.52.88]:38474 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751308AbbFJSlo (ORCPT ); Wed, 10 Jun 2015 14:41:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,588,1427785200"; d="scan'208";a="708744883" From: Andi Kleen To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 00/10] x86/asm: Compile-time asm code validation References: <20150610130814.GN19417@two.firstfloor.org> <20150610135203.GA19509@treble.redhat.com> <20150610141104.GQ19417@two.firstfloor.org> <20150610143209.GA28843@treble.redhat.com> <20150610150412.GR19417@two.firstfloor.org> <20150610153155.GB29724@treble.redhat.com> <20150610165056.GC29724@treble.redhat.com> Date: Wed, 10 Jun 2015 11:41:43 -0700 In-Reply-To: <20150610165056.GC29724@treble.redhat.com> (Josh Poimboeuf's message of "Wed, 10 Jun 2015 11:50:56 -0500") Message-ID: <87h9qf5rtk.fsf@tassilo.jf.intel.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 26 Josh Poimboeuf writes: > > If you're wanting something like -freorder-blocks-and-partition for asm > code, maybe we could implement something analagous to the > likely()/unlikely() macros, to allow the hot and cold portions to be > placed into different sections. (I could then teach asmvalidate how to > validate such code.) > > Would that be useful? Eventually you have to handle dwarf4, because that's the only way to handle the gcc generated code. So your tool just needs to understand the dwarf. It's ok to warn about assembler code that is not correctly annotated, and fix it then. -Andi -- ak@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/