Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964914AbbFJTaY (ORCPT ); Wed, 10 Jun 2015 15:30:24 -0400 Received: from mail-vn0-f53.google.com ([209.85.216.53]:36870 "EHLO mail-vn0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964848AbbFJTaP (ORCPT ); Wed, 10 Jun 2015 15:30:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433159555-4704-1-git-send-email-baolin.wang@linaro.org> Date: Wed, 10 Jun 2015 12:30:13 -0700 X-Google-Sender-Auth: u-M5eSe9j1F6Cq1Po8m8to2oh2U Message-ID: Subject: Re: [PATCH v4 04/25] security/security: Introduce security_settime64() function with timespec64 type From: Kees Cook To: Baolin Wang Cc: Serge Hallyn , Arnd Bergmann , Greg KH , LKML , James Morris , "Serge E. Hallyn" , Paul Moore , Takashi Iwai , Jeffrey Vander Stoep , Jeffrey Layton , Stephen Smalley , mark.d.rustad@intel.com, linux-security-module , y2038 Mailman List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1874 Lines: 51 On Tue, Jun 9, 2015 at 8:14 PM, Baolin Wang wrote: > On 6 June 2015 at 12:27, Baolin Wang wrote: >> On 6 June 2015 at 04:04, Kees Cook wrote: >>> On Mon, Jun 1, 2015 at 4:52 AM, Baolin Wang >>> wrote: >>> > include/linux/security.h | 25 ++++++++++++++++++++----- >>> > security/commoncap.c | 2 +- >>> > security/security.c | 2 +- >>> > 3 files changed, 22 insertions(+), 7 deletions(-) >>> >>> We certainly want this in, but this area has been rather radically >>> refactored recently. Can you rebase this patch against security-next? >>> > > Hi Kees, > > I have rebased my patch series, but can not find your refactored code. > Could you tell me the commit information? Thanks a lot! It lives in security-next, but you could use linux-next too. This is what I see on a trivial patch attempt: checking file include/linux/security.h Hunk #1 succeeded at 69 with fuzz 1 (offset -6 lines). Hunk #2 FAILED at 1353. Hunk #3 FAILED at 1483. Hunk #4 succeeded at 206 (offset -1584 lines). Hunk #5 succeeded at 463 (offset -1583 lines). 2 out of 5 hunks FAILED (Stripping trailing CRs from patch; use --binary to disable.) checking file security/commoncap.c Hunk #1 succeeded at 111 (offset -5 lines). (Stripping trailing CRs from patch; use --binary to disable.) checking file security/security.c Hunk #1 succeeded at 213 with fuzz 2 (offset -11 lines). See http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/ or maybe I misunderstood your question? Thanks! -Kees -- Kees Cook Chrome OS Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/