Message-ID: <1433965193.32331.23.camel@perches.com>
Subject: Re: [RFC][PATCH] printk: Fixup the nmi printk mess
From: Joe Perches <joe@perches.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        jkosina@suse.cz, paulmck@linux.vnet.ibm.com, pmladek@suse.cz,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Date: Wed, 10 Jun 2015 12:39:53 -0700
In-Reply-To: <20150610192516.GK3644@twins.programming.kicks-ass.net>
References: <20150610125509.GO19282@twins.programming.kicks-ass.net>
	 <20150610120242.1e33c752@gandalf.local.home>
	 <1433953156.32331.4.camel@perches.com>
	 <20150610192516.GK3644@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 839
Lines: 21

On Wed, 2015-06-10 at 21:25 +0200, Peter Zijlstra wrote:
> On Wed, Jun 10, 2015 at 09:19:16AM -0700, Joe Perches wrote:
> > On Wed, 2015-06-10 at 12:02 -0400, Steven Rostedt wrote:
> > 
> > > BTW, the printk.c file is getting rather big.
> > 
> > No joke that.
> 
> $ find kernel/ -type f -name \*.[ch] | while read file; do wc -l $file; done | sort -nr | awk '{ print ++i " " $0 }' | grep "\<printk\.c"
> 13 3245 kernel/printk/printk.c
> 
> so its the 13th biggest file in kernel/, can't really be bothered by that.

printk.c is ~80k of fairly convoluted.
Refactoring would help maintenance.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/