Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932404AbbFJT7u (ORCPT ); Wed, 10 Jun 2015 15:59:50 -0400 Received: from mailsec111.isp.belgacom.be ([195.238.20.107]:60564 "EHLO mailsec111.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550AbbFJT7l convert rfc822-to-8bit (ORCPT ); Wed, 10 Jun 2015 15:59:41 -0400 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=z2WTV4mAI6UWamCjDJCdLIA+c/M+fkeu8SyhGDYh7nk= c=1 sm=2 a=IkcTkHD0fZMA:10 a=IJv9LcIfAAAA:8 a=Pdgiqm1rt2WOUJySdgsA:9 a=QEXdDO2ut3YA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2BRIAAwlnhV/9MU7sNcgxCBM4MeqGEGkgsBBIdaAoE9Pw0BAQEBAQEBgQpBA4NeAQEBAQIBIwRSBQsFBAIYAgIYDgICVwYTEYgVDJEQnRmGVJ05AQEIAiCBIYR4hSqEUzMHgmiBRQWsRoo1JGKBWYE/PDGCRwEBAQ Date: Wed, 10 Jun 2015 21:59:38 +0200 (CEST) From: Fabian Frederick Reply-To: Fabian Frederick To: Joe Perches Cc: "Luis R. Rodriguez" , Nick Kossifidis , linux-wireless@vger.kernel.org, Jiri Slaby , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Julia Lawall , Kalle Valo Message-ID: <1121998377.24127.1433966378845.open-xchange@webmail.nmp.proximus.be> In-Reply-To: <1433965966.32331.25.camel@perches.com> References: <1433954015-24872-1-git-send-email-fabf@skynet.be> <1433965966.32331.25.camel@perches.com> Subject: Re: [PATCH 1/1 linux-next] ath5k: use swap() in ath5k_hw_get_median_noise_floor() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.2.2-Rev27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1498 Lines: 43 > On 10 June 2015 at 21:52 Joe Perches wrote: > > > On Wed, 2015-06-10 at 18:33 +0200, Fabian Frederick wrote: > > Use kernel.h macro definition. > > > > Thanks to Julia Lawall for Coccinelle scripting support. > [] > > diff --git a/drivers/net/wireless/ath/ath5k/phy.c > > b/drivers/net/wireless/ath/ath5k/phy.c > [] > > @@ -1566,17 +1566,13 @@ static s16 > >  ath5k_hw_get_median_noise_floor(struct ath5k_hw *ah) > >  { > >     s16 sort[ATH5K_NF_CAL_HIST_MAX]; > > -   s16 tmp; > >     int i, j; > >  > >     memcpy(sort, ah->ah_nfcal_hist.nfval, sizeof(sort)); > >     for (i = 0; i < ATH5K_NF_CAL_HIST_MAX - 1; i++) { > >             for (j = 1; j < ATH5K_NF_CAL_HIST_MAX - i; j++) { > > -                   if (sort[j] > sort[j - 1]) { > > -                           tmp = sort[j]; > > -                           sort[j] = sort[j - 1]; > > -                           sort[j - 1] = tmp; > > -                   } > > +                   if (sort[j] > sort[j - 1]) > > +                           swap(sort[j], sort[j]); > > swap(a, a) doesn't look useful. Thanks a lot Joe, I'll fix this one :) Regards, Fabian > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/