Date: Wed, 10 Jun 2015 18:36:56 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Kees Cook <keescook@chromium.org>, "CC: Ingo Molnar" <mingo@kernel.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>, Oleg Nesterov <oleg@redhat.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Alexei Starovoitov <ast@plumgrid.com>, Will Drewry <wad@chromium.org>,
        "x86@kernel.org" <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH] x86/asm/entry/32, selftests: Add test_syscall_vdso test
Message-ID: <20150610183656.6adeedb6@gandalf.local.home>
In-Reply-To: <55789AFE.80408@redhat.com>
References: <1433955570-15957-1-git-send-email-dvlasenk@redhat.com>
	<CAGXu5jK6d0AoW5PpUrA_LY_WjNRoXBoe4bciSdsyO78BG_rduQ@mail.gmail.com>
	<55789AFE.80408@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 831
Lines: 23

On Wed, 10 Jun 2015 22:15:58 +0200
Denys Vlasenko <dvlasenk@redhat.com> wrote:

> On 06/10/2015 10:00 PM, Kees Cook wrote:
> >> +       printf("[SKIP]\tAT_SYSINFO not supplied, can't test\n");
> >> +       exit(0); /* this is not a test failure */
> > 
> > Why is that not a test failure? It would mean it didn't actually test
> > anything, which seems like a failure to me.
> 
> Are you objecting to comment wording, or to exiting with 0?
> 
> I exit with 0 because no bug was detected.

I believe there's a way to exit with "not supported". That's what the
ftrace tests do.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/