Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932667AbbFJWls (ORCPT ); Wed, 10 Jun 2015 18:41:48 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:51457 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752417AbbFJWlk (ORCPT ); Wed, 10 Jun 2015 18:41:40 -0400 Date: Wed, 10 Jun 2015 23:41:34 +0100 From: Russell King - ARM Linux To: Min-Hua Chen Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3 2/2] arm: use max_lowmem_limit in find_limit() Message-ID: <20150610224134.GS7557@n2100.arm.linux.org.uk> References: <1433962773-8402-1-git-send-email-orca.chen@gmail.com> <1433962773-8402-3-git-send-email-orca.chen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433962773-8402-3-git-send-email-orca.chen@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 974 Lines: 23 On Thu, Jun 11, 2015 at 02:59:33AM +0800, Min-Hua Chen wrote: > In commit: 1c2f87c22566cd057bc8cde10c37ae9da1a1bb76, the max_low is > set by memblock_get_current_limit(). However memblock.current_limit > can be changed by memblock_set_current_limit() any point before > find_limits(). > > It's better to use arm_lowmem_limit to be max_lowmem in two ways: > First, arm_lowmem_limit cannot be changed by a public API. Second, the > high_memory is set by arm_lowmem_limit and is a natural limit of > low memory area in bootmem_init(). > > Signed-off-by: Min-Hua Chen NAK, this is a known build breaker. -- FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up according to speedtest.net. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/