Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932271AbbFJXAz (ORCPT ); Wed, 10 Jun 2015 19:00:55 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:37447 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbbFJXAq (ORCPT ); Wed, 10 Jun 2015 19:00:46 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433272747-27114-1-git-send-email-ttnguyen@apm.com> <1433272747-27114-3-git-send-email-ttnguyen@apm.com>

Date: Wed, 10 Jun 2015 16:00:45 -0700 Message-ID: Subject: Re: [PATCH 2/2 RESEND] power: reset: Add syscon poweroff device node for APM X-Gene platform From: Moritz Fischer To: Dann Frazier Cc: Tai Tri Nguyen , arm@kernel.org, "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , linux-arm-kernel , patches , Jon Masters Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3789 Lines: 107 On Wed, Jun 10, 2015 at 12:13 PM, Dann Frazier wrote: > On Tue, Jun 9, 2015 at 9:31 AM, Dann Frazier wrote: >> On Mon, Jun 8, 2015 at 10:34 PM, Tai Tri Nguyen wrote: >>> Hi Dann, >>> >>> On Mon, Jun 8, 2015 at 8:44 PM, Dann Frazier wrote: >>>> On Tue, Jun 2, 2015 at 1:19 PM, Tai Nguyen wrote: >>>>> This patch adds syscon poweroff device node to support poweroff feature >>>>> on APM X-Gene Mustang platform >>>> >>>> hey Tai, >>>> The reboot changes work just fine for me, but poweroff does not: >>>> >>>> [ OK ] Reached target Final Step. >>>> Starting Power-Off... >>>> reboot: Power down >>>> Unable to poweroff system >>>> Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 >>>> >>>> CPU: 0 PID: 1 Comm: systemd-shutdow Tainted: G W 4.1.0-rc7+ #1 >>>> Hardware name: APM X-Gene Mustang board (DT) >>>> Call trace: >>>> [] dump_backtrace+0x0/0x11c >>>> [] show_stack+0x10/0x1c >>>> [] dump_stack+0x88/0xc8 >>>> [] panic+0xe0/0x220 >>>> [] do_exit+0x990/0x994 >>>> [] SyS_reboot+0x14c/0x208 >>>> ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000000 >>>> >>>> -dann >>>> >>> >>> Thanks for testing my patches. >>> On APM X-Gene Mustang platform, power off circuit is controlled by firmware. >>> It requires a firmware update to support power off feature. >>> May I ask what firmware version you're running on? >> >> Sure, 1.15.12. > > Tai worked with me offline. For reference, this requires an updated > SlimPro firmware in addition to the u-boot update. Verified it works > for me after the update, so: > > Tested-by: dann frazier Looks good. Acked-by: Moritz Fischer > >> -dann >> >>> Tai >>> >>> >>>>> Signed-off-by: Tai Nguyen >>>>> --- >>>>> arch/arm64/boot/dts/apm/apm-mustang.dts | 12 ++++++++++++ >>>>> 1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/apm/apm-mustang.dts b/arch/arm64/boot/dts/apm/apm-mustang.dts >>>>> index 83578e7..910d561 100644 >>>>> --- a/arch/arm64/boot/dts/apm/apm-mustang.dts >>>>> +++ b/arch/arm64/boot/dts/apm/apm-mustang.dts >>>>> @@ -23,6 +23,18 @@ >>>>> device_type = "memory"; >>>>> reg = < 0x1 0x00000000 0x0 0x80000000 >; /* Updated by bootloader */ >>>>> }; >>>>> + >>>>> + poweroff_mbox: poweroff_mbox@10548000 { >>>>> + compatible = "syscon"; >>>>> + reg = <0x0 0x10548000 0x0 0x30>; >>>>> + }; >>>>> + >>>>> + poweroff: poweroff@10548010 { >>>>> + compatible = "syscon-poweroff"; >>>>> + regmap = <&poweroff_mbox>; >>>>> + offset = <0x10>; >>>>> + mask = <0x1>; >>>>> + }; >>>>> }; >>>>> >>>>> &pcie0clk { >>>>> -- >>>>> 1.7.9.5 >>>>> >>>>> >>>>> _______________________________________________ >>>>> linux-arm-kernel mailing list >>>>> linux-arm-kernel@lists.infradead.org >>>>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >>> >>> >>> >>> -- >>> Tai > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/