Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752015AbbFJXxF (ORCPT ); Wed, 10 Jun 2015 19:53:05 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:62502 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751392AbbFJXxA (ORCPT ); Wed, 10 Jun 2015 19:53:00 -0400 From: "Rafael J. Wysocki" To: Jassi Brar Cc: Feng Kan , patches , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , Mika Westerberg , Darren Hart Subject: Re: [PATCH V2 RESEND] mailbox: add ACPI support for mailbox framework Date: Thu, 11 Jun 2015 02:18:48 +0200 Message-ID: <3651207.H4iW8oXRCh@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <1428537507-30561-1-git-send-email-fkan@apm.com> <2931755.BICyILJPre@vostro.rjw.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1448 Lines: 34 On Wednesday, April 29, 2015 08:22:37 AM Jassi Brar wrote: > On Wed, Apr 22, 2015 at 7:34 AM, Rafael J. Wysocki wrote: > > On Tuesday, April 21, 2015 04:53:14 PM Jassi Brar wrote: > >> On Tue, Apr 21, 2015 at 6:28 AM, Feng Kan wrote: > >> > > >> > Just want to ping this. I haven't gotten any response from mailbox > >> > maintainer for this > >> > patch or any of my other mailbox patches. > >> > > >> Sorry I had been busy and still need to have a critical look at the > >> new api. It would sooth my nerves to see an ACK from some acpi god. > > > > I'm far from one, but I'll be looking at this is detail next week if > > that helps (this week I'm traveling). > > > No, you are one on my list :) Your review from acpi perspective will > be greatly helpful. The code changes look reasonable to me, but it would be good to point to the DT property definition this is supposed to follow in the changelog (ie. where exactly this is defined for DT). The "mboxes" _DSD property will need to be registered at some point in the future too when the infrastructure for that is ready. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/