Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754197AbbFKBCK (ORCPT ); Wed, 10 Jun 2015 21:02:10 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:34846 "EHLO mail-qk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750761AbbFKBCD (ORCPT ); Wed, 10 Jun 2015 21:02:03 -0400 MIME-Version: 1.0 In-Reply-To: <20150611005956.GA515@swordfish> References: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> <1433851493-23685-5-git-send-email-sergey.senozhatsky@gmail.com> <20150610235836.GB499@swordfish> <1433983686.32331.35.camel@perches.com> <20150611005956.GA515@swordfish> From: Dan Streetman Date: Wed, 10 Jun 2015 21:01:42 -0400 X-Google-Sender-Auth: Lfu2rJTB5d1X5FgeW2ZbGvoemVg Message-ID: Subject: Re: [RFC][PATCH 4/5] mm/zpool: allow NULL `zpool' pointer in zpool_destroy_pool() To: Sergey Senozhatsky Cc: Joe Perches , Sergey Senozhatsky , Andrew Morton , Minchan Kim , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Michal Hocko , David Rientjes , Linux-MM , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1429 Lines: 42 On Wed, Jun 10, 2015 at 8:59 PM, Sergey Senozhatsky wrote: > On (06/10/15 17:48), Joe Perches wrote: > [..] >> > > > For consistency, tweak zpool_destroy_pool() and NULL-check the >> > > > pointer there. >> > > > >> > > > Proposed by Andrew Morton. >> > > > >> > > > Signed-off-by: Sergey Senozhatsky >> > > > Reported-by: Andrew Morton >> > > > LKML-reference: https://lkml.org/lkml/2015/6/8/583 >> > > >> > > Acked-by: Dan Streetman >> > >> > Thanks. >> > >> > Shall we ask Joe to add zpool_destroy_pool() to the >> > "$func(NULL) is safe and this check is probably not required" list? >> >> [] >> >> Is it really worth it? >> >> There isn't any use of zpool_destroy_pool preceded by an if >> There is one and only one use of zpool_destroy_pool. >> > > Yes, that's why I asked. I don't think that zpool_destroy_pool() > will gain any significant amount of users soon (well, who knows), > so I'm fine with keeping it out of checkpatch checks. Just checked > your opinion. I really doubt if zpool will be used by anyone other than zswap anytime soon. > > -ss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/