Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750816AbbFKEW6 (ORCPT ); Thu, 11 Jun 2015 00:22:58 -0400 Received: from cantor2.suse.de ([195.135.220.15]:52955 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750717AbbFKEWw (ORCPT ); Thu, 11 Jun 2015 00:22:52 -0400 Date: Thu, 11 Jun 2015 06:22:49 +0200 (CEST) From: Jiri Kosina To: Pavel Machek cc: Josh Poimboeuf , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros In-Reply-To: <20150610181732.GB2993@amd> Message-ID: References: <6b0f0a275e240eb4f6889eea8863875041f05bba.1433937132.git.jpoimboe@redhat.com> <20150610181732.GB2993@amd> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1236 Lines: 40 On Wed, 10 Jun 2015, Pavel Machek wrote: > > diff --git a/arch/x86/include/asm/func.h b/arch/x86/include/asm/func.h > > new file mode 100644 > > index 0000000..4d62782 > > --- /dev/null > > +++ b/arch/x86/include/asm/func.h > > @@ -0,0 +1,24 @@ > > +#ifndef _ASM_X86_FUNC_H > > +#define _ASM_X86_FUNC_H > > + > > +#include > > +#include > > + > > +/* > > + * These are frame pointer save and restore macros. They should be used by > > + * every callable non-leaf asm function. > > + */ > > +.macro FP_SAVE name > > + .if CONFIG_FRAME_POINTER > > + push %_ASM_BP > > + _ASM_MOV %_ASM_SP, %_ASM_BP > > + .endif > > +.endm > > Hmm. This will not compile when included into .c file. Should it have > other extension than .h? (Or can the macros be done in different way? We have quite a few of .h headers in the kernel already which are supposed to be included only by .S files, so what exactly is the problem you are seeing here? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/