Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752631AbbFKIMF (ORCPT ); Thu, 11 Jun 2015 04:12:05 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53312 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752064AbbFKIL4 (ORCPT ); Thu, 11 Jun 2015 04:11:56 -0400 Date: Thu, 11 Jun 2015 10:11:51 +0200 From: Jean Delvare To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Julia Lawall , Guenter Roeck , lm-sensors@lm-sensors.org Subject: Re: [PATCH 1/1 linux-next] hwmon: (w83627ehf) use swap() in w82627ehf_swap_tempreg() Message-ID: <20150611101151.6ca81769@endymion.delvare> In-Reply-To: <1433953981-24515-1-git-send-email-fabf@skynet.be> References: <1433953981-24515-1-git-send-email-fabf@skynet.be> Organization: SUSE Linux X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.23; x86_64-suse-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1937 Lines: 58 On Wed, 10 Jun 2015 18:33:01 +0200, Fabian Frederick wrote: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick > --- > drivers/hwmon/w83627ehf.c | 26 +++++--------------------- > 1 file changed, 5 insertions(+), 21 deletions(-) > > diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c > index b10353b..697007a 100644 > --- a/drivers/hwmon/w83627ehf.c > +++ b/drivers/hwmon/w83627ehf.c > @@ -1937,27 +1937,11 @@ static inline void w83627ehf_init_device(struct w83627ehf_data *data, > static void w82627ehf_swap_tempreg(struct w83627ehf_data *data, > int r1, int r2) > { > - u16 tmp; > - > - tmp = data->temp_src[r1]; > - data->temp_src[r1] = data->temp_src[r2]; > - data->temp_src[r2] = tmp; > - > - tmp = data->reg_temp[r1]; > - data->reg_temp[r1] = data->reg_temp[r2]; > - data->reg_temp[r2] = tmp; > - > - tmp = data->reg_temp_over[r1]; > - data->reg_temp_over[r1] = data->reg_temp_over[r2]; > - data->reg_temp_over[r2] = tmp; > - > - tmp = data->reg_temp_hyst[r1]; > - data->reg_temp_hyst[r1] = data->reg_temp_hyst[r2]; > - data->reg_temp_hyst[r2] = tmp; > - > - tmp = data->reg_temp_config[r1]; > - data->reg_temp_config[r1] = data->reg_temp_config[r2]; > - data->reg_temp_config[r2] = tmp; > + swap(data->temp_src[r1], data->temp_src[r2]); > + swap(data->reg_temp[r1], data->reg_temp[r2]); > + swap(data->reg_temp_over[r1], data->reg_temp_over[r2]); > + swap(data->reg_temp_hyst[r1], data->reg_temp_hyst[r2]); > + swap(data->reg_temp_config[r1], data->reg_temp_config[r2]); > } > > static void Looks good. Applied, thanks. -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/