Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752763AbbFKIvY (ORCPT ); Thu, 11 Jun 2015 04:51:24 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:37288 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697AbbFKIvP (ORCPT ); Thu, 11 Jun 2015 04:51:15 -0400 Date: Thu, 11 Jun 2015 09:51:10 +0100 From: Lee Jones To: Rob Herring Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, arm@kernel.org, Samuel Ortiz , Linus Walleij , Milo Kim , Kumar Gala , Andy Gross , David Brown , Tony Lindgren , patches@opensource.wolfsonmicro.com, linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH 09/15] mfd: kill off set_irq_flags usage Message-ID: <20150611085110.GF2982@x1> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-10-git-send-email-robh@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1433874401-27161-10-git-send-email-robh@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2971 Lines: 73 On Tue, 09 Jun 2015, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Samuel Ortiz > Cc: Lee Jones > Cc: Linus Walleij > Cc: Milo Kim > Cc: Kumar Gala > Cc: Andy Gross > Cc: David Brown > Cc: Tony Lindgren > Cc: linux-arm-kernel@lists.infradead.org > Cc: patches@opensource.wolfsonmicro.com > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-soc@vger.kernel.org > Cc: linux-omap@vger.kernel.org > --- > drivers/mfd/88pm860x-core.c | 4 ---- > drivers/mfd/ab8500-core.c | 4 ---- > drivers/mfd/arizona-irq.c | 7 ------- > drivers/mfd/asic3.c | 4 ++-- > drivers/mfd/db8500-prcmu.c | 1 - > drivers/mfd/ezx-pcap.c | 6 +----- > drivers/mfd/htc-egpio.c | 4 ++-- > drivers/mfd/htc-i2cpld.c | 6 +----- > drivers/mfd/lp8788-irq.c | 5 ----- > drivers/mfd/max8925-core.c | 5 +---- > drivers/mfd/max8997-irq.c | 5 +---- > drivers/mfd/max8998-irq.c | 5 +---- > drivers/mfd/mt6397-core.c | 4 ---- > drivers/mfd/pm8921-core.c | 5 +---- > drivers/mfd/rc5t583-irq.c | 4 +--- > drivers/mfd/stmpe.c | 7 ------- > drivers/mfd/t7l66xb.c | 6 ------ > drivers/mfd/tc3589x.c | 7 ------- > drivers/mfd/tc6393xb.c | 4 ++-- > drivers/mfd/tps6586x.c | 7 ------- > drivers/mfd/tps65912-irq.c | 8 +------- > drivers/mfd/twl4030-irq.c | 11 +---------- > drivers/mfd/twl6030-irq.c | 13 ------------- > drivers/mfd/ucb1x00-core.c | 2 +- > drivers/mfd/wm831x-irq.c | 7 ------- > drivers/mfd/wm8350-irq.c | 8 +------- > drivers/mfd/wm8994-irq.c | 7 ------- > 27 files changed, 17 insertions(+), 139 deletions(-) Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/