Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754208AbbFKJia (ORCPT ); Thu, 11 Jun 2015 05:38:30 -0400 Received: from mga01.intel.com ([192.55.52.88]:57518 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752554AbbFKJiP (ORCPT ); Thu, 11 Jun 2015 05:38:15 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,594,1427785200"; d="scan'208";a="709106556" Date: Thu, 11 Jun 2015 12:38:08 +0300 From: Mika Westerberg To: christian.ruppert@alitech.com Cc: Christian Ruppert , Fabio Mello , Jarkko Nikula , linux-i2c@vger.kernel.org, lkml , Lucas De Marchi , Lucas De Marchi , Wolfram Sang Subject: Re: [PATCH] i2c: designware: use enable on resume instead initialization Message-ID: <20150611093808.GS1478@lahna.fi.intel.com> References: <1433785828-4100-1-git-send-email-lucas.de.marchi@gmail.com> <20150609085146.GD1478@lahna.fi.intel.com> <20150610070722.GM1478@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 744 Lines: 13 On Wed, Jun 10, 2015 at 05:05:16PM +0200, christian.ruppert@alitech.com wrote: > We should understand why the controller was disabled after successful > transfers in the first place, however. Maybe some quirk with older > versions of the hardware? Mika, do you have any memories about this? I think it was in the original driver even before I did Intel specific changes to that. I have no idea why it is done. Probably, like you said, because some older version of the hardware needed it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/