Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932113AbbFKMP7 (ORCPT ); Thu, 11 Jun 2015 08:15:59 -0400 Received: from eusmtp01.atmel.com ([212.144.249.243]:52996 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754444AbbFKMPm (ORCPT ); Thu, 11 Jun 2015 08:15:42 -0400 Date: Thu, 11 Jun 2015 14:16:08 +0200 From: Ludovic Desroches To: Cyrille Pitchen CC: , , , , , Subject: Re: [PATCH 1/1] i2c: at91: fix code checker warnings Message-ID: <20150611121608.GW25800@odux.rfo.atmel.com> Mail-Followup-To: Cyrille Pitchen , wsa@the-dreams.de, linux-i2c@vger.kernel.org, nicolas.ferre@atmel.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <7419376c5a4e60f1b23d36e66a102c7c40db1089.1434013494.git.cyrille.pitchen@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <7419376c5a4e60f1b23d36e66a102c7c40db1089.1434013494.git.cyrille.pitchen@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 52 On Thu, Jun 11, 2015 at 11:16:32AM +0200, Cyrille Pitchen wrote: > buf_len is a size_t, so unsigned but was tested with '<= 0'. > > Signed-off-by: Cyrille Pitchen Acked-by: Ludovic Desroches Thanks > --- > drivers/i2c/busses/i2c-at91.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c > index 0d2dc7d..967c0cb 100644 > --- a/drivers/i2c/busses/i2c-at91.c > +++ b/drivers/i2c/busses/i2c-at91.c > @@ -232,7 +232,7 @@ static void at91_twi_dma_cleanup(struct at91_twi_dev *dev) > > static void at91_twi_write_next_byte(struct at91_twi_dev *dev) > { > - if (dev->buf_len <= 0) > + if (!dev->buf_len) > return; > > /* 8bit write works with and without FIFO */ > @@ -275,7 +275,7 @@ static void at91_twi_write_data_dma(struct at91_twi_dev *dev) > struct dma_chan *chan_tx = dma->chan_tx; > unsigned int sg_len = 1; > > - if (dev->buf_len <= 0) > + if (!dev->buf_len) > return; > > dma->direction = DMA_TO_DEVICE; > @@ -347,7 +347,7 @@ error: > > static void at91_twi_read_next_byte(struct at91_twi_dev *dev) > { > - if (dev->buf_len <= 0) > + if (!dev->buf_len) > return; > > /* 8bit read works with and without FIFO */ > -- > 1.8.2.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/