Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbbFKMhC (ORCPT ); Thu, 11 Jun 2015 08:37:02 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:41050 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750825AbbFKMg5 (ORCPT ); Thu, 11 Jun 2015 08:36:57 -0400 Date: Thu, 11 Jun 2015 14:36:54 +0200 From: Pavel Machek To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Len Brown , linux-pm@vger.kernel.org Subject: Re: [PATCH v5 07/10] x86/asm/acpi: Fix asmvalidate warnings for wakeup_64.S Message-ID: <20150611123654.GA24528@amd> References: <2817f5690aa760a601a614b738545fd60b087bbb.1433937132.git.jpoimboe@redhat.com> <20150610131914.GA25572@amd> <20150610140830.GA25848@treble.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150610140830.GA25848@treble.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1384 Lines: 49 Hi! > > > 5. Remove superfluous rsp changes. > > > > Did you test the changes? > > Yes, I verified that it didn't break suspend/resume on my system. Ok, so I can not see anything wrong, either. I'd like to understand why the original code manipulated %rsp, but... If you did testing with frame pointer on, you can get my Acked-by: Pavel Machek > > Do you plan to make similar changes to wakeup_32.S? > > Currently, asmvalidate is x86_64 only, so I'm only fixing the 64-bit > stuff right now. Well, you are "improving debuggability", afaict. It worked well before. > > > @@ -108,8 +108,9 @@ ENTRY(do_suspend_lowlevel) > > > movq pt_regs_r15(%rax), %r15 > > > > > > xorl %eax, %eax > > > - addq $8, %rsp > > > - jmp restore_processor_state > > > + call restore_processor_state > > > + FP_RESTORE > > > + ret > > > ENDPROC(do_suspend_lowlevel) > > > > Umm. I rather liked the direct jump. > > Why? It is both smaller and faster than the new code. But... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/