Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932494AbbFKNEg (ORCPT ); Thu, 11 Jun 2015 09:04:36 -0400 Received: from mail-la0-f66.google.com ([209.85.215.66]:35417 "EHLO mail-la0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754636AbbFKNE2 (ORCPT ); Thu, 11 Jun 2015 09:04:28 -0400 Message-ID: <55798759.8000607@gmail.com> Date: Thu, 11 Jun 2015 15:04:25 +0200 From: Mats Karrman User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sebastian Andrzej Siewior , Vinod Koul , Mark Brown CC: linux-rt-users , LKML , Thomas Gleixner , rostedt@goodmis.org, John Kacur , Fernando Lopez-Lezcano , alsa-devel@alsa-project.org, Jie Yang Subject: Re: [PATCH] ASoC: Intel: sst: use ; instead of , at the of a C statement References: <20150519213923.GA26363@linutronix.de> <55623BC2.80307@localhost> <20150611122227.GF16115@linutronix.de> In-Reply-To: <20150611122227.GF16115@linutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1481 Lines: 35 On 2015-06-11 14:22, Sebastian Andrzej Siewior wrote: > This was spotted by Fernando Lopez-Lezcano > while he tried to compile a -RT kernel with this driver enabled. > "make C=2" would also warn about this. This is is based on his patch. > > Reported-by: Fernando Lopez-Lezcano > Signed-off-by: Sebastian Andrzej Siewior > --- > sound/soc/intel/atom/sst/sst.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c > index 96c2e420cce6..b0c3e0e56302 100644 > --- a/sound/soc/intel/atom/sst/sst.c > +++ b/sound/soc/intel/atom/sst/sst.c > @@ -368,8 +368,8 @@ static inline void sst_restore_shim64(struct intel_sst_drv *ctx, > * initialize by FW or driver when firmware is loaded > */ > spin_lock_irqsave(&ctx->ipc_spin_lock, irq_flags); > - sst_shim_write64(shim, SST_IMRX, shim_regs->imrx), > - sst_shim_write64(shim, SST_CSR, shim_regs->csr), > + sst_shim_write64(shim, SST_IMRX, shim_regs->imrx): Don't you mean ';' and not ':'? > + sst_shim_write64(shim, SST_CSR, shim_regs->csr); > spin_unlock_irqrestore(&ctx->ipc_spin_lock, irq_flags); > } > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/