Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751594AbbFKOSK (ORCPT ); Thu, 11 Jun 2015 10:18:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48162 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbbFKOSG (ORCPT ); Thu, 11 Jun 2015 10:18:06 -0400 Date: Thu, 11 Jun 2015 09:18:04 -0500 From: Josh Poimboeuf To: Pavel Machek Cc: Jiri Kosina , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Peter Zijlstra , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v5 01/10] x86/asm: Add FP_SAVE/RESTORE frame pointer macros Message-ID: <20150611141804.GA12084@treble.redhat.com> References: <6b0f0a275e240eb4f6889eea8863875041f05bba.1433937132.git.jpoimboe@redhat.com> <20150610181732.GB2993@amd> <20150611064633.GA817@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150611064633.GA817@amd> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2049 Lines: 61 On Thu, Jun 11, 2015 at 08:46:33AM +0200, Pavel Machek wrote: > On Thu 2015-06-11 06:22:49, Jiri Kosina wrote: > > On Wed, 10 Jun 2015, Pavel Machek wrote: > > > > > > diff --git a/arch/x86/include/asm/func.h b/arch/x86/include/asm/func.h > > > > new file mode 100644 > > > > index 0000000..4d62782 > > > > --- /dev/null > > > > +++ b/arch/x86/include/asm/func.h > > > > @@ -0,0 +1,24 @@ > > > > +#ifndef _ASM_X86_FUNC_H > > > > +#define _ASM_X86_FUNC_H > > > > + > > > > +#include > > > > +#include > > > > + > > > > +/* > > > > + * These are frame pointer save and restore macros. They should be used by > > > > + * every callable non-leaf asm function. > > > > + */ > > > > +.macro FP_SAVE name > > > > + .if CONFIG_FRAME_POINTER > > > > + push %_ASM_BP > > > > + _ASM_MOV %_ASM_SP, %_ASM_BP > > > > + .endif > > > > +.endm > > > > > > Hmm. This will not compile when included into .c file. Should it have > > > other extension than .h? (Or can the macros be done in different way? > > > > We have quite a few of .h headers in the kernel already which are supposed > > to be included only by .S files, so what exactly is the problem you are > > seeing here? > > Such as...? Can this be merged into one of them so that we don't have > a separate file? For example "frame.h"? > > (I thought asm includes traditionally had different extension, but I > may be mistaken). > > And at the very least, dwarf2.h includes > > #ifndef __ASSEMBLY__ > #warning "asm/dwarf2.h should be only included in pure assembly files" > #endif > > and guards stuff that would not compile in C with > > #ifdef __ASSEMBLY__ > .... Ok, I'll move the FP_SAVE/RESTORE stuff into frame.h (which seems to be completely unused). And I'll make sure to use "#ifdef __ASSEMBLY__". -- Josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/