Message-ID: <5579A226.3070704@linaro.org>
Date: Thu, 11 Jun 2015 16:58:46 +0200
From: Daniel Lezcano <daniel.lezcano@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Viresh Kumar <viresh.kumar@linaro.org>
CC: Thomas Gleixner <tglx@linutronix.de>, linaro-kernel@lists.linaro.org,
        linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Srinivas Kandagatla <srinivas.kandagatla@gmail.com>,
        Maxime Coquelin <maxime.coquelin@st.com>,
        Patrice Chotard <patrice.chotard@st.com>
Subject: Re: [PATCH 2/6] clocksource: arm_global_timer: Migrate to new 'set-state'
 interface
References: <cover.1433768426.git.viresh.kumar@linaro.org> <54f346e663f605e2f078a3114de85ba281d1e6d0.1433768426.git.viresh.kumar@linaro.org> <5579A011.8030900@linaro.org> <20150611145654.GB4386@linux>
In-Reply-To: <20150611145654.GB4386@linux>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1281
Lines: 35

On 06/11/2015 04:56 PM, Viresh Kumar wrote:
> On 11-06-15, 16:49, Daniel Lezcano wrote:
>> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Thanks :)
>
>>> -	clk->set_mode = gt_clockevent_set_mode;
>>> +	clk->set_state_shutdown = gt_clockevent_shutdown;
>>> +	clk->set_state_periodic = gt_clockevent_set_periodic;
>>> +	clk->set_state_oneshot = gt_clockevent_shutdown;
>>
>> nit: it sounds weird to use the same function as the purpose of the
>> patch is use the new API which is to ventilate those functions
>> (anyway ...)
>
> Hmm, but there is no point creating two routines to do exactly the
> same thing. And this is making it evident that we actually shutdown
> the device in oneshot-state request. And enable it only when the next
> event is programmed.

Yes, this is really a detail.


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/