Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751729AbbFKPZ0 (ORCPT ); Thu, 11 Jun 2015 11:25:26 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:37845 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbbFKPZY (ORCPT ); Thu, 11 Jun 2015 11:25:24 -0400 Message-ID: <5579A864.5010500@linaro.org> Date: Thu, 11 Jun 2015 17:25:24 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Viresh Kumar , Thomas Gleixner CC: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren , Lee Jones Subject: Re: [PATCH 3/6] clocksource: bcm2835: Migrate to new 'set-state' interface References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2783 Lines: 77 On 06/08/2015 03:40 PM, Viresh Kumar wrote: > Migrate bcm2835 driver to the new 'set-state' interface provided by > the clockevents core, the earlier 'set-mode' interface is marked > obsolete now. > > This also enables us to implement callbacks for new states of clockevent > devices, for example: ONESHOT_STOPPED. Please mention in the log you removed the RESUME because it does nothing and the core code will just ignore it. > Cc: Stephen Warren > Cc: Lee Jones > Signed-off-by: Viresh Kumar Acked-by: Daniel Lezcano > --- > drivers/clocksource/bcm2835_timer.c | 17 ++++------------- > 1 file changed, 4 insertions(+), 13 deletions(-) > > diff --git a/drivers/clocksource/bcm2835_timer.c b/drivers/clocksource/bcm2835_timer.c > index 26ed331b1aad..b59b8e1ba503 100644 > --- a/drivers/clocksource/bcm2835_timer.c > +++ b/drivers/clocksource/bcm2835_timer.c > @@ -54,19 +54,9 @@ static u64 notrace bcm2835_sched_read(void) > return readl_relaxed(system_clock); > } > > -static void bcm2835_time_set_mode(enum clock_event_mode mode, > - struct clock_event_device *evt_dev) > +static int bcm2835_time_noop(struct clock_event_device *evt) > { > - switch (mode) { > - case CLOCK_EVT_MODE_ONESHOT: > - case CLOCK_EVT_MODE_UNUSED: > - case CLOCK_EVT_MODE_SHUTDOWN: > - case CLOCK_EVT_MODE_RESUME: > - break; > - default: > - WARN(1, "%s: unhandled event mode %d\n", __func__, mode); > - break; > - } > + return 0; > } > > static int bcm2835_time_set_next_event(unsigned long event, > @@ -129,7 +119,8 @@ static void __init bcm2835_timer_init(struct device_node *node) > timer->evt.name = node->name; > timer->evt.rating = 300; > timer->evt.features = CLOCK_EVT_FEAT_ONESHOT; > - timer->evt.set_mode = bcm2835_time_set_mode; > + timer->evt.set_state_shutdown = bcm2835_time_noop; > + timer->evt.set_state_oneshot = bcm2835_time_noop; The patch is ok but there is an inconsistency on how are handled the different callbacks. tick_resume can be omitted but not state_shutdown and state_oneshot forcing the drivers to define empty functions. > timer->evt.set_next_event = bcm2835_time_set_next_event; > timer->evt.cpumask = cpumask_of(0); > timer->act.name = node->name; -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/