Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753472AbbFKPi3 (ORCPT ); Thu, 11 Jun 2015 11:38:29 -0400 Received: from forward2o.mail.yandex.net ([37.140.190.31]:50062 "EHLO forward2o.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbbFKPiY (ORCPT ); Thu, 11 Jun 2015 11:38:24 -0400 X-Greylist: delayed 440 seconds by postgrey-1.27 at vger.kernel.org; Thu, 11 Jun 2015 11:38:24 EDT From: Evgeniy Polyakov Envelope-From: drustafa@yandex.ru To: Dan Carpenter Cc: Greg Kroah-Hartman , David Fries , Matt Campbell , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" In-Reply-To: <20150604090412.GE22838@mwanda> References: <20150602121255.GA20149@spacedout.fries.net> <20150604090412.GE22838@mwanda> Subject: Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show() MIME-Version: 1.0 Message-Id: <1064021434036660@web13o.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Thu, 11 Jun 2015 18:31:00 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 25 Hi 04.06.2015, 12:04, "Dan Carpenter" : > I noticed there was a problem here because Smatch complained: > > ????????drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn: > ????????inconsistent returns 'mutex:&sl->master->mutex'. > ??????????Locked on: line 416 > ??????????Unlocked on: line 413 > > The problem is that we lock ->mutex but we unlock ->bus_mutex on error. > David Fries says that ->bus_mutex is correct and ->mutex is incorrect. > > Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm') > Signed-off-by: Dan Carpenter Looks good to me, Greg please pull this serie into your tree, if you hadn't yet. Am I right that this is a stable tree material too? Acked-by: Evgeniy Polyakov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/