Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752281AbbFKPhj (ORCPT ); Thu, 11 Jun 2015 11:37:39 -0400 Received: from mail.kernel.org ([198.145.29.136]:42305 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751663AbbFKPhg (ORCPT ); Thu, 11 Jun 2015 11:37:36 -0400 Date: Thu, 11 Jun 2015 12:37:30 -0300 From: Arnaldo Carvalho de Melo To: "Liang, Kan" Cc: "linux-kernel@vger.kernel.org" , "Huang, Ying" , "andi@firstfloor.org" Subject: Re: [PATCH 1/1] perf,tools: add time out to force stop endless mmap processing Message-ID: <20150611153730.GA3195@kernel.org> References: <1433922364-22580-1-git-send-email-kan.liang@intel.com> <20150611140614.GC2696@kernel.org> <37D7C6CF3E00A74B8858931C1DB2F07701875D03@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F07701875D03@SHSMSX103.ccr.corp.intel.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 27 Em Thu, Jun 11, 2015 at 02:27:40PM +0000, Liang, Kan escreveu: > > Em Wed, Jun 10, 2015 at 03:46:04AM -0400, kan.liang@intel.com escreveu: > > > perf top reads all threads' /proc/xxx/maps. If there is any threads > > > which generating a keeping growing huge /proc/xxx/maps, perf will do > > > infinite loop in perf_event__synthesize_mmap_events. > > > This patch fixes this issue by adding a time out to force stop this > > > kind of endless mmap processing. > > > > > > Reported-by: Huang, Ying > > > Signed-off-by: Kan Liang > > > > So we will silently stop processing those events? > > > > We will make progress, no doubt, but I think the user needs to be warned > > about this situation, so that later on when/if samples for those maps > > appear and don't get resolved at least we will know that this is the reason. > I will add warning message for this kind of time out. Thanks! - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/