Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbFKPiX (ORCPT ); Thu, 11 Jun 2015 11:38:23 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:36160 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752439AbbFKPiT (ORCPT ); Thu, 11 Jun 2015 11:38:19 -0400 MIME-Version: 1.0 In-Reply-To: <1433891440-3515-1-git-send-email-toshi.kani@hp.com> References: <1433891440-3515-1-git-send-email-toshi.kani@hp.com> Date: Thu, 11 Jun 2015 08:38:18 -0700 Message-ID: Subject: Re: [PATCH v2 0/3] Add NUMA support for NVDIMM devices From: Dan Williams To: Toshi Kani Cc: "Rafael J. Wysocki" , Linux ACPI , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , Rafael J Wysocki Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1839 Lines: 43 On Tue, Jun 9, 2015 at 4:10 PM, Toshi Kani wrote: > Since NVDIMMs are installed on memory slots, they expose the NUMA > topology of a platform. This patchset adds support of sysfs > 'numa_node' to I/O-related NVDIMM devices under /sys/bus/nd/devices. > This enables numactl(8) to accept 'block:' and 'file:' paths of > pmem and btt devices as shown in the examples below. > numactl --preferred block:pmem0 --show > numactl --preferred file:/dev/pmem0s --show > > numactl can be used to bind an application to the locality of > a target NVDIMM for better performance. Here is a result of fio > benchmark to ext4/dax on an HP DL380 with 2 sockets for local and > remote settings. > > Local [1] : 4098.3MB/s > Remote [2]: 3718.4MB/s > > [1] numactl --preferred block:pmem0 --cpunodebind block:pmem0 fio > [2] numactl --preferred block:pmem1 --cpunodebind block:pmem1 fio > > Patch 1/3 applies on top of the acpica branch of the pm tree. > Patch 2/3-3/3 apply on top of Dan Williams's v5 patch series of > "libnvdimm: non-volatile memory devices". > > --- > v2: > - Add acpi_map_pxm_to_online_node(), which returns an online node. > - Manage visibility of sysfs numa_node with is_visible. (Dan Williams) > - Check ACPI_NFIT_PROXIMITY_VALID in spa->flags. > > --- > Toshi Kani (3): > 1/3 acpi: Add acpi_map_pxm_to_online_node() > 2/3 libnvdimm: Set numa_node to NVDIMM devices > 3/3 libnvdimm: Add sysfs numa_node to NVDIMM devices Looks good to me. Once Rafael acks the ACPI core changes I'll pull it in to libnvdimm-for-next. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/