Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752873AbbFKQA4 (ORCPT ); Thu, 11 Jun 2015 12:00:56 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:35787 "EHLO mail-pd0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751159AbbFKQAy (ORCPT ); Thu, 11 Jun 2015 12:00:54 -0400 Date: Thu, 11 Jun 2015 21:30:48 +0530 From: Viresh Kumar To: Daniel Lezcano Cc: Thomas Gleixner , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Stephen Warren , Lee Jones Subject: Re: [PATCH 3/6] clocksource: bcm2835: Migrate to new 'set-state' interface Message-ID: <20150611160048.GC4386@linux> References: <5579A864.5010500@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5579A864.5010500@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 760 Lines: 21 On 11-06-15, 17:25, Daniel Lezcano wrote: > Please mention in the log you removed the RESUME because it does > nothing and the core code will just ignore it. Okay. > The patch is ok but there is an inconsistency on how are handled the > different callbacks. tick_resume can be omitted but not > state_shutdown and state_oneshot forcing the drivers to define empty > functions. It was done because they are thought to be compulsory, but even I am not sure if we should make all callbacks as optional. -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/