Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbbFKQSr (ORCPT ); Thu, 11 Jun 2015 12:18:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42075 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751963AbbFKQSq (ORCPT ); Thu, 11 Jun 2015 12:18:46 -0400 Date: Thu, 11 Jun 2015 11:18:43 -0500 From: David Teigland To: Guoqing Jiang Cc: Bob Peterson , ccaulfie@redhat.com, cluster-devel@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [Cluster-devel] [PATCH] dlm: remove unnecessary error check Message-ID: <20150611161843.GA20918@redhat.com> References: <1433843172-8953-1-git-send-email-gqjiang@suse.com> <1545280635.13245793.1433851749238.JavaMail.zimbra@redhat.com> <5577A36D.5010908@suse.com> <70321158.13952725.1433904643714.JavaMail.zimbra@redhat.com> <5577AAB4.20700@suse.com> <20150610152438.GB333@redhat.com> <55795930.1030608@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55795930.1030608@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 564 Lines: 14 On Thu, Jun 11, 2015 at 05:47:28PM +0800, Guoqing Jiang wrote: > Do you consider take the following clean up? If yes, I will send a > formal patch, otherwise pls ignore it. On first glance, the old and new code do not appear to do the same thing, so let's leave it as it is. > - to_nodeid = dlm_dir_nodeid(r); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/