Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965140AbbFKRiS (ORCPT ); Thu, 11 Jun 2015 13:38:18 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50946 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752465AbbFKRiL (ORCPT ); Thu, 11 Jun 2015 13:38:11 -0400 Date: Thu, 11 Jun 2015 10:40:56 -0700 From: Andrew Morton To: Christoph Lameter Cc: Sergey Senozhatsky , Minchan Kim , Pekka Enberg , Joonsoo Kim , Michal Hocko , David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, sergey.senozhatsky.work@gmail.com, Joe Perches Subject: Re: [RFC][PATCH 0/5] do not dereference NULL pools in pools' destroy() functions Message-Id: <20150611104056.5d2122dd.akpm@linux-foundation.org> In-Reply-To: References: <1433851493-23685-1-git-send-email-sergey.senozhatsky@gmail.com> <20150609142523.b717dba6033ee08de997c8be@linux-foundation.org> <20150609185150.8c9fed8d.akpm@linux-foundation.org> <20150609191755.867a36c3.akpm@linux-foundation.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 26 On Thu, 11 Jun 2015 12:26:11 -0500 (CDT) Christoph Lameter wrote: > On Tue, 9 Jun 2015, Andrew Morton wrote: > > > > > More than half of the kmem_cache_destroy() callsites are declining that > > > > value by open-coding the NULL test. That's reality and we should recognize > > > > it. > > > > > > Well that may just indicate that we need to have a look at those > > > callsites and the reason there to use a special cache at all. > > > > This makes no sense. Go look at the code. > > drivers/staging/lustre/lustre/llite/super25.c, for example. It's all > > in the basic unwind/recover/exit code. > > That is screwed up code. I'd do that without the checks simply with a > series of kmem_cache_destroys(). So go and review some of the many other callers which do this. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/