Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755496AbbFKUWZ (ORCPT ); Thu, 11 Jun 2015 16:22:25 -0400 Received: from mail-qg0-f65.google.com ([209.85.192.65]:36695 "EHLO mail-qg0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752912AbbFKUWV (ORCPT ); Thu, 11 Jun 2015 16:22:21 -0400 Date: Thu, 11 Jun 2015 13:08:44 -0700 From: Dmitry Torokhov To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Julia Lawall , Ferruh Yigit , linux-input@vger.kernel.org Subject: Re: [PATCH 1/1 linux-next] Input: cyttsp4 - use swap() in cyttsp4_get_touch() Message-ID: <20150611200844.GA10293@dtor-pixel> References: <1433953903-23653-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433953903-23653-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1483 Lines: 44 On Wed, Jun 10, 2015 at 06:31:43PM +0200, Fabian Frederick wrote: > Use kernel.h macro definition. > > Thanks to Julia Lawall for Coccinelle scripting support. > > Signed-off-by: Fabian Frederick Applied, thank you. > --- > drivers/input/touchscreen/cyttsp4_core.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/input/touchscreen/cyttsp4_core.c b/drivers/input/touchscreen/cyttsp4_core.c > index 568a3d3..5ed3105 100644 > --- a/drivers/input/touchscreen/cyttsp4_core.c > +++ b/drivers/input/touchscreen/cyttsp4_core.c > @@ -775,7 +775,6 @@ static void cyttsp4_get_touch(struct cyttsp4_mt_data *md, > struct device *dev = &md->input->dev; > struct cyttsp4_sysinfo *si = md->si; > enum cyttsp4_tch_abs abs; > - int tmp; > bool flipped; > > for (abs = CY_TCH_X; abs < CY_TCH_NUM_ABS; abs++) { > @@ -790,9 +789,7 @@ static void cyttsp4_get_touch(struct cyttsp4_mt_data *md, > } > > if (md->pdata->flags & CY_FLAG_FLIP) { > - tmp = touch->abs[CY_TCH_X]; > - touch->abs[CY_TCH_X] = touch->abs[CY_TCH_Y]; > - touch->abs[CY_TCH_Y] = tmp; > + swap(touch->abs[CY_TCH_X], touch->abs[CY_TCH_Y]); > flipped = true; > } else > flipped = false; > -- > 2.4.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/