Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754982AbbFKUh4 (ORCPT ); Thu, 11 Jun 2015 16:37:56 -0400 Received: from mail-ie0-f170.google.com ([209.85.223.170]:35028 "EHLO mail-ie0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130AbbFKUhz (ORCPT ); Thu, 11 Jun 2015 16:37:55 -0400 MIME-Version: 1.0 In-Reply-To: <1434031637-9091-8-git-send-email-mingo@kernel.org> References: <1434031637-9091-1-git-send-email-mingo@kernel.org> <1434031637-9091-8-git-send-email-mingo@kernel.org> Date: Thu, 11 Jun 2015 13:37:54 -0700 X-Google-Sender-Auth: qZTR8jdHfGHPiTWdgxOmtIPQuLQ Message-ID: Subject: Re: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code From: Linus Torvalds To: Ingo Molnar Cc: Linux Kernel Mailing List , linux-mml@vger.kernel.org, Andy Lutomirski , Andrew Morton , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , Oleg Nesterov , Thomas Gleixner , Waiman Long Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 714 Lines: 22 On Thu, Jun 11, 2015 at 7:07 AM, Ingo Molnar wrote: > > But we want to remove the pgd_list, so convert the code over to walk > all tasks in the system. This is an equivalent method. This is not at all equivalent, and it looks stupid. Don't use "for_each_process_thread(g, p)". You only care about each mm, and threads all share the same mm, so just do for_each_process(p) instead of iterating over all threads too. No? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/