Message-ID: <1434058075.2477.178.camel@freescale.com>
Subject: Re: [PATCH v2] powerpc: support sizes greater than an unsigned long
From: Scott Wood <scottwood@freescale.com>
To: Cristian Stoica <cristian.stoica@freescale.com>
CC: <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
        <horia.geanta@freescale.com>
Date: Thu, 11 Jun 2015 16:27:55 -0500
In-Reply-To: <5579B2FC.4010008@freescale.com>
References: <1431620684-20123-1-git-send-email-cristian.stoica@freescale.com>
	 <1431683064-29584-1-git-send-email-cristian.stoica@freescale.com>
	 <55799E38.1000004@freescale.com> <20150611153835.GB5058@kroah.com>
	 <5579B2FC.4010008@freescale.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2015 21:28:04.5843
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR03MB1482
X-Microsoft-Exchange-Diagnostics: 1;BY1PR03MB1498;2:LctNRtqTUzfWCU3VN9CDychFWId1GzhBt7XbEkaZFTN47Zs/e9JGUWX/eNUOP8yq;2:NFyGrk8R79TuGGkSz6R5AqHWA3BbAawfFPzJnK9YMGcmfaXDcUbVUJMT1Tsr4azS3eYLx3u9GYCLP/P24XfHPHL+apNd3e5WTd7/sKmabZgPf4oBv2qLeL52F9RSvQe/VlHEN8kyfzppnzGbSwHWlQ==;9:lqByWuu2KAahvhvVi5uLsJToeaNJD9F1cGiRwiw6R7DBwlEpKDx3Ao6AxR9CL2FSgEL2RfSWwk3fLTr9kaWlgSKcgre+a0W9xaWFYQhs7hIpmOLDU/tjeDfaeZqoa82Hnu4sK/VLRqJlNfeLEb8RyQ==
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1391
Lines: 36

On Thu, 2015-06-11 at 19:10 +0300, Cristian Stoica wrote:
> On 06/11/2015 06:38 PM, Greg KH wrote:
> > On Thu, Jun 11, 2015 at 05:42:00PM +0300, Cristian Stoica wrote:
> > 
> > Why?
> > 
> 
> This patch matches the input argument "size" of ioremap() with the 
> output of request_mem_region() (which is
> resource_size_t).
> Since the latter is used as input to the former, the types should 
> match (even though mapping more than 4G is not usually
> expected). There are a lot of such differences in the code and this 
> is an attempt to reduce that.

Dropping the upper bits of the size harms the ability to detect error 
scenarios where unmappably large -- but not power-of-two -- regions 
are requested to be mapped.

However, this patch doesn't fix that.  It just postpones the loss of 
the upper 32 bits until __ioremap_caller() calls get_vm_area_caller().

There's also no error checking at all for the size of ioremap() done 
during early boot (!slab_is_available()).

Don't just blindly turn static analyzer reports into patches -- and 
why didn't the analyzer complain about the call to 
get_vm_area_caller() after this patch?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/