Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752962AbbFKXl5 (ORCPT ); Thu, 11 Jun 2015 19:41:57 -0400 Received: from SpacedOut.fries.net ([67.64.210.234]:41107 "EHLO SpacedOut.fries.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbbFKXlw (ORCPT ); Thu, 11 Jun 2015 19:41:52 -0400 Date: Thu, 11 Jun 2015 18:41:33 -0500 From: David Fries To: Evgeniy Polyakov Cc: Dan Carpenter , Greg Kroah-Hartman , Matt Campbell , "linux-kernel@vger.kernel.org" , "kernel-janitors@vger.kernel.org" Subject: Re: [patch] [patch 2/2 v2] w1: use correct lock on error in w1_seq_show() Message-ID: <20150611234133.GM27260@spacedout.fries.net> References: <20150602121255.GA20149@spacedout.fries.net> <20150604090412.GE22838@mwanda> <1064021434036660@web13o.yandex.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1064021434036660@web13o.yandex.ru> User-Agent: Mutt/1.5.23 (2014-03-12) X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.5.11 (SpacedOut.fries.net [127.0.0.1]); Thu, 11 Jun 2015 18:41:35 -0500 (CDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 30 On Thu, Jun 11, 2015 at 06:31:00PM +0300, Evgeniy Polyakov wrote: > Hi > > 04.06.2015, 12:04, "Dan Carpenter" : > > I noticed there was a problem here because Smatch complained: > > > > ????????drivers/w1/slaves/w1_therm.c:416 w1_seq_show() warn: > > ????????inconsistent returns 'mutex:&sl->master->mutex'. > > ??????????Locked on: line 416 > > ??????????Unlocked on: line 413 > > > > The problem is that we lock ->mutex but we unlock ->bus_mutex on error. > > David Fries says that ->bus_mutex is correct and ->mutex is incorrect. > > > > Fixes: d9411e57dc7f ('w1: Add support for DS28EA00 sequence to w1-therm') > > Signed-off-by: Dan Carpenter > > Looks good to me, Greg please pull this serie into your tree, if you hadn't yet. > Am I right that this is a stable tree material too? I would expect the answer to be no. This is a fix to a new feature that is in gregkh/char-misc but not yet in Linus's tree. -- David Fries -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/