Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752194AbbFLBsr (ORCPT ); Thu, 11 Jun 2015 21:48:47 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:34798 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750808AbbFLBsq (ORCPT ); Thu, 11 Jun 2015 21:48:46 -0400 Date: Fri, 12 Jun 2015 10:48:31 +0900 From: Tejun Heo To: Rusty Russell Cc: Linus Torvalds , Louis Langholtz , Linux Kernel Mailing List , trivial@kernel.org, Andrew Morton Subject: Re: [PATCH] kernel/params.c: make use of unused but set variable Message-ID: <20150612014831.GG6336@mtj.duckdns.org> References: <1433721270-9182-1-git-send-email-lou_langholtz@me.com> <20150608000007.GA3543@mtj.duckdns.org> <87zj45g1hf.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zj45g1hf.fsf@rustcorp.com.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 872 Lines: 23 On Fri, Jun 12, 2015 at 10:57:24AM +0930, Rusty Russell wrote: > Linus Torvalds writes: > > On Sun, Jun 7, 2015 at 5:00 PM, Tejun Heo wrote: > > At most, it could be a "WARN_ON_ONCE()". Maybe even just silently > > ignore the error. But BUG_ON()? Hell no. > > Yeah, in practice it's already (1) paniced if we ran out of memory, or > (2) warned if we somehow tried to create two entries with the same name. > > So the WARN_ON_ONCE() is a bit... meh. How's this, too snarky? Sounds pretty passive agressive to me. At least reply to the actual argument? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/