Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752917AbbFLGra (ORCPT ); Fri, 12 Jun 2015 02:47:30 -0400 Received: from mail-db3on0130.outbound.protection.outlook.com ([157.55.234.130]:10814 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751170AbbFLGr2 convert rfc822-to-8bit (ORCPT ); Fri, 12 Jun 2015 02:47:28 -0400 From: "Abdul, Hussain (H.)" To: "gregkh@linuxfoundation.org" CC: "vthakkar1994@gmail.com" , "hamohammed.sa@gmail.com" , "tapaswenipathak@gmail.com" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag Thread-Topic: [PATCH] staging: ste_rmi4: Add IRQF_ONESHOT flag Thread-Index: AQHQpC9ywh9+V5hJVkuiMF5NnnVAVQ== Date: Fri, 12 Jun 2015 06:47:25 +0000 Message-ID: References: <1434017608-20304-1-git-send-email-habdul@visteon.com> <20150611143640.GA24637@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linuxfoundation.org; dkim=none (message not signed) header.d=none; x-originating-ip: [74.112.164.117] x-microsoft-exchange-diagnostics: 1;DB5PR06MB1111;3:fHeaJ9Be6A0+/PqNY8EKRuZzg4IvEa1/jpWyl/cwEFliqXZXPMT3o0RRf2W0ZLKDfW/+tNUIrYvv2CLjQXQGBAYJm4Mru0M90ux4UsZzQu4CJZdmjAKHnIdWCZwPVGFTV67i+b7mZXZzZ0zI0NDMng==;10:m99JtgUbkhQYMt7s6UEwbDu4xkAn3KOu2wxoHBcqynkDtpAL+sS+Z0/jXXdAcgGZagGiHVTkUl2NtjcpFNtujnbOREyBTQgtsADpn3Qrx68=;6:7Ax0oT/4Nh8YFqSlzQjoEG+gF49AzdOvi0237nZyM6BMydeDJWMGW2S+qTaXxN/G x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1111; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(520003)(3002001);SRVR:DB5PR06MB1111;BCL:0;PCL:0;RULEID:;SRVR:DB5PR06MB1111; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(24454002)(377454003)(51704005)(5002640100001)(2656002)(5001960100002)(19580405001)(19580395003)(86362001)(87936001)(77096005)(102836002)(189998001)(62966003)(110136002)(106116001)(77156002)(76176999)(74316001)(54356999)(2501003)(50986999)(92566002)(5003600100002)(76576001)(2351001)(33656002)(122556002)(40100003)(46102003)(66066001);DIR:OUT;SFP:1102;SCL:1;SRVR:DB5PR06MB1111;H:DB5PR06MB1112.eurprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jun 2015 06:47:25.9056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB5PR06MB1111 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 35 On Thursday 11 June 2015 08:06 PM, gregkh@linuxfoundation.org wrote: > On Thu, Jun 11, 2015 at 10:14:49AM +0000, Abdul, Hussain (H.) wrote: >> This patch add IRQF_ONESHOT flag in threaded IRQs request without a primary handler. >> >> Signed-off-by: Abdul Hussain >> --- >> drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c >> index 0f524bb..7caaae0 100644 >> --- a/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c >> +++ b/drivers/staging/ste_rmi4/synaptics_i2c_rmi4.c >> @@ -987,7 +987,7 @@ static int synaptics_rmi4_probe >> rmi4_data->number_of_interrupt_register); >> retval = request_threaded_irq(client->irq, NULL, >> synaptics_rmi4_irq, >> - platformdata->irq_type, >> + platformdata->irq_type | IRQF_ONESHOT, >> DRIVER_NAME, rmi4_data); >> if (retval) { >> dev_err(&client->dev, "Unable to get attn irq %d\n", > Have you tested this? This changes the behavior of the code, right? > Greg, I haven't tested this changes. Yes, this will change the behavior of the code. Thanks Abdul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/