Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753380AbbFLG6u (ORCPT ); Fri, 12 Jun 2015 02:58:50 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:33377 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781AbbFLG6t (ORCPT ); Fri, 12 Jun 2015 02:58:49 -0400 MIME-Version: 1.0 In-Reply-To: <5579CFCC.60905@xilinx.com> References: <1433945584-16379-1-git-send-email-achandran@mvista.com> <5579CFCC.60905@xilinx.com> Date: Fri, 12 Jun 2015 12:28:48 +0530 Message-ID: Subject: Re: [PATCH v1] ARM: zynq: Fix earlyprintk in big endian mode From: Arun Chandran To: Michal Simek Cc: "linux-kernel@vger.kernel.org" , Michal Simek , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1398 Lines: 43 On Thu, Jun 11, 2015 at 11:43 PM, Michal Simek wrote: > On 06/10/2015 04:13 PM, Arun Chandran wrote: >> earlyprintk messages are not appearing on the terminal >> emulator during a big endian kernel boot. If we >> byte swap the sending data it comes properly. >> >> Signed-off-by: Arun Chandran >> --- >> --- >> This can be tested by adding 'early_print("early print test\n");' >> to setup_arch() in arch/arm/kernel/setup.c >> --- >> arch/arm/include/debug/zynq.S | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm/include/debug/zynq.S b/arch/arm/include/debug/zynq.S >> index bd13ded..0d274fe 100644 >> --- a/arch/arm/include/debug/zynq.S >> +++ b/arch/arm/include/debug/zynq.S >> @@ -38,6 +38,7 @@ >> .endm >> >> .macro senduart,rd,rx >> +ARM_BE8( rev \rd, \rd ) >> str \rd, [\rx, #UART_FIFO_OFFSET] @ TXDATA >> .endm >> >> > > Tested-by: Michal Simek > I think just using strb instead of str will do the work much better. I have send v2 with that logic Thanks for testing it. --Arun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/