Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755019AbbFLHwv (ORCPT ); Fri, 12 Jun 2015 03:52:51 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:34978 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751107AbbFLHwt (ORCPT ); Fri, 12 Jun 2015 03:52:49 -0400 Date: Fri, 12 Jun 2015 09:52:44 +0200 From: Ingo Molnar To: "Jonathan (Zhixiong) Zhang" Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, Matt Fleming , fu.wei@linaro.org, al.stone@linaro.org, bp@alien8.de, tony.luck@gmail.com, ying.huang@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 1/4] x86: acpi: define uncached page flag Message-ID: <20150612075244.GB8759@gmail.com> References: <1434047160-23358-1-git-send-email-zjzhang@codeaurora.org> <1434047160-23358-2-git-send-email-zjzhang@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1434047160-23358-2-git-send-email-zjzhang@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1268 Lines: 44 * Jonathan (Zhixiong) Zhang wrote: > From: "Jonathan (Zhixiong) Zhang" > > This definition is used in APEI code when needing to map pages as > uncached. > > Signed-off-by: Jonathan (Zhixiong) Zhang > --- > arch/x86/include/asm/acpi.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/x86/include/asm/acpi.h b/arch/x86/include/asm/acpi.h > index 3a45668f6dc3..6afb27682b00 100644 > --- a/arch/x86/include/asm/acpi.h > +++ b/arch/x86/include/asm/acpi.h > @@ -138,6 +138,10 @@ static inline void disable_acpi(void) { } > > #endif /* !CONFIG_ACPI */ > > +#ifdef CONFIG_ACPI_APEI > +#define ARCH_APEI_PAGE_KERNEL_UC (PAGE_KERNEL_NOCACHE) > +#endif /*CONFIG_ACPI_APEI */ - Why the tab? - Why the parentheses? - Why the closing comment block for a oneliner define? It's not like we forget what it's about. - When the missing space in the closing comment? That's 4 uglies in 3 lines of code, wow ... Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/