Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751606AbbFLI0n (ORCPT ); Fri, 12 Jun 2015 04:26:43 -0400 Received: from mail-bl2on0147.outbound.protection.outlook.com ([65.55.169.147]:11200 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750859AbbFLI0i (ORCPT ); Fri, 12 Jun 2015 04:26:38 -0400 X-Greylist: delayed 171935 seconds by postgrey-1.27 at vger.kernel.org; Fri, 12 Jun 2015 04:26:38 EDT Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; lists.ozlabs.org; dkim=none (message not signed) header.d=none; Date: Fri, 12 Jun 2015 16:09:32 +0800 From: Zidan Wang To: Nicolin Chen CC: , , , , , , , , Subject: Re: [alsa-devel][PATCH] ASoC: fsl: add imx-wm8960 machine driver Message-ID: <20150612080930.GB23608@shlinux2> References: <20150610183619.GA3103@Asurada-CZ80> <20150611110958.GA23742@shlinux2> <20150611155106.GA3036@Asurada> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20150611155106.GA3036@Asurada> User-Agent: Mutt/1.5.21 (2010-09-15) X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD031;1:afAxsEP5O1jV5zUyZQiVOPMRVvTRNUCgtBzPRqePmAzH7jOW5Qd7he88BIn+1aHvaeHFj1gF49KH8nO5pTR9/xGCocShX7/3R/G5U8ybHBpI9bXEa6U0mcvtBNm8ZLG8YNgC1ooS/dkpDXj80TPJ6YS6K0TtsW+Cfmnpil57wn/wrBxY7anEM0bn8UOn9FXPbo/OjiCmAjbBQV/tBOtusKNCUmSpANptuPj05EPG7GvwI2Bwy11EVj9ZXkDnx8BSAW7gzMET37E0KBumVS1yNYhhI9MXldnvLcD6e4AiljOvBaH41wJ1b9gQgJX0fZtgYNA/piPX7fTOr7EpAFRnFQ== X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(189002)(199003)(24454002)(51704005)(87936001)(46406003)(2950100001)(6806004)(97756001)(33656002)(77156002)(33716001)(62966003)(50466002)(104016003)(110136002)(54356999)(5001960100002)(50986999)(92566002)(47776003)(105606002)(106466001)(46102003)(4001350100001)(83506001)(86362001)(76176999)(23726002)(19580405001)(189998001)(77096005)(19580395003)(93886004)(85426001);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR03MB607;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:sfv;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB607;2:EQMkgsBgTQWtZwqvTCTFoWPe1ETeD+2pqSuPDGWEmqM0TJsBXUsYmc8SrdbD/Vjw;2:YiobGI8ePCAqPsG5poAeEDD4wxOygWGOif7njRyxFn3X3YAvsoR5ucjZrluvFMTKvc5qULZWBcCPYewm3Jaj4j1HakbOYMmBTP3S5Ewy0EvXq1UezUlR1Z1PnDQamy99JeMyyNcpfln8ABnhy/PYVTq0kjkIgdrXaX1SxjiP7YbJFUbmldbNjHJxA87s++NCEtsb+cEGfJtc2AO4trJF+u5pFdyVb6aNIc2rBnKkeL8=;6:R3w+uYY1+xeysBa4geDWYigkoRcXjvs30z3bFAb9U3hnl5iUNMI4BfaBFKFzPSOTW+vGf79K9y9C5EUMLtyVZRtc4C1i/+oT661PqIlKQ9m5WPNP6U/bk3E97WXjx46+Ld1uQQhfuEFGpXxTBIkDdK1NW35EckUfzVvl2/PW4kvXeTRv1fDalnAxGkerePOQKznezXBc8VrNATz8L1a736LS4yy+BAc4MvGOy3R/e5cIQnpTXb/F3RZHsCFPU31MuNg5E1WBoq7a3CzJyfv8FPkhNhN+K3xgHYO6F4Uaewj2zl97v9SIJ8VlVdAj60I/rz1wiqCbSsQDtdlnRXPyug==;3:VephoL8UwmKQ3L7YDTiIYrXOttR/bH6sKdm2n/v7AK8+bpTU78/PUUrv1iIZxtup0AgFblR1xMeRE87XTzybp9hNDHUI00m+BCHsnBUnY4n6dIwi4mvHFOSC+eGBHBB1VmttD2dASTjSK3PzRaX3jmx5SOh/n3X/o1F2ixSZTNnzkVBtIlB8YbUEfPYsAp8etw0Av2LlUVgnjPZB3g+9Fj9SvjNnsnHUGjclLoL4N91ZVd/PnMX/wtfdrnxkRCCI+QMBxIf6PPwDJKohpYIqxPy6+fZ94Gdhp2nVPljhW5Hb7PTMdtrLT1CwH9/IVA4S X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB607; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520003)(5005006)(3002001);SRVR:BY2PR03MB607;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB607; X-Forefront-PRVS: 060503E79B X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BY2PR03MB607;9:Kd6P1cnWG3iBnQmVKZSJPCxeks+stQi47rz9uhf9icF?= =?us-ascii?Q?94JrVUvDhC8CMbELy7sakdnjSrd0NxZ7vcUnykAcxLk2hcKIYMyZCaEQ9Ez/?= =?us-ascii?Q?H1oBMjaoSIGQdOb/3UMv968Io1jqIzo0iLYUbj4ee/aI8CyjMz5CcPwjY9ue?= =?us-ascii?Q?s9ttCOZQ6ojDS4RtQwFhB/0u/1/N4NxrSwDv6e745LQXaYryf8zyiq+QrwEs?= =?us-ascii?Q?ywcBsliAcJnWcmQ8G1puzp5wNWEFVVXxUqk3lmtz3PvJEv+U7J6k2fwYFk7h?= =?us-ascii?Q?OA8l+v71Y7PJVdVJ+A0u7UlVlfrGiBvESPiVYyC50cWtU084pVVHc4l0OxM7?= =?us-ascii?Q?d3/vbvd3NYW4nlaGVJkyOxw27FOafUqVCGrKUKlbEHQUgoV9p69Qu6NkUZ8/?= =?us-ascii?Q?oY4Ldp42DKS7axNGo1fAOxupWy43wG4Pexw0UqqQigNTy5adyJClaeTmAVIX?= =?us-ascii?Q?WH5GBWMrjHuHUGI8NHFFTe7U3x03iWDA/fqhyILbnkgEc+h6tQnn9/u4QIrI?= =?us-ascii?Q?aHsBaXyABLRuUiF9sSNoSjVzJ6fjB1pFhRnpXI/cwZAEIfEQszm+j/8ICjLY?= =?us-ascii?Q?+eEVmNP4gHwQ2RGMuMGhM2ocX86fIFM5q9AP6GY/1jL9QHmdShwpDwhXha2V?= =?us-ascii?Q?m01p1g9MHFNwjzzbkMGWye7wzNbqnLBtZCdkTjPcU+Gh8s5jyUJ75/Lt8nwv?= =?us-ascii?Q?RFTgMAA7CkiTfpYKduP2AfERhnfjbyGttuuQz4Vc5rmq9r2MFnk2q42saWHp?= =?us-ascii?Q?4DwOBu+wlTYbiJwhIBZROS+RPMuubiNxBW6IJqnY/ol68uI+UeYZwmdSIwFS?= =?us-ascii?Q?iheonhvvEz+X0dxtOYpDddHs85uWwm7Hg9GozrmTqNxkGDtTQMOyW+9jZiqN?= =?us-ascii?Q?ff1MZNdu9DlA18QQnUPDOMcEHQ520qEUQzVv3pSg+s77Ur+U/LV9JdtvpYVm?= =?us-ascii?Q?jNAVWH6P2czx4n5NSkAtxIw7h2CLRGnILCA4ryQ=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2PR03MB607;3:BHkmbVQf9YjWERd3P/UTCtxI/lDTSRklJN9YTA4XT8lHE6GAfl/uPFpkYjAJmOavGmyBdcqK0WN/qacAdjXf16JD0N1/pWB6zQdymrmfI2P8xyJAtHbQ0GqhsEpaAXYTptgJPL1irhHc4RjZVd2V1g==;10:5/yDrKFm3CdJTNxyEey5sRfFD+tbD/dkf8owNAaLhcmnTT48PqMXAIYR5LZNvobsJ8xKIxAbL/1FYwLJ3JBrqxuOABeDu4zmErrObVkA+Bk=;6:Xmtf9b3cA/Gn/NDvCGAGsOvBQnR3NRuJSsCylqi2Fw72jUNJZ5jM4NjeW+KEnzwN X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jun 2015 08:11:25.6637 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB607 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1853 Lines: 42 On Thu, Jun 11, 2015 at 08:51:07AM -0700, Nicolin Chen wrote: > On Thu, Jun 11, 2015 at 07:10:00PM +0800, Zidan Wang wrote: > > > > > This imx-wm8960 device-tree-only machine driver works with sai driver > > > > and have below feature. > > > > * support codec master and slave mode > > > > * support headphone jack detect > > > > * support headphone and micphone jack event > > > > * support asrc<->sai<->wm8960 mode > > > > > > > > Signed-off-by: Zidan Wang > > > > > > Above all, could you merge this into fsl-asoc-card? > > > > > > It'd be nicer to have jack detection over there. And we can > > > put PLL settings to the codec driver as Mark suggested. > > > I want to modify imx-wm8960 and upstream it because our release is using it now. After > > upstreaming imx-wm8960, i will try to merge it to fsl-asoc-card. > > I knew your intention. That's why I suggested you to merge it directly > to fsl-asoc-card instead of making a duplicated copy of that. Remember > that getting code upstream should be a chance for us to improve thing. > > If you find painstaking to handle it in parallel, you can focus on the > improvements of the WM8960 driver while I would help you on the dai- > link part. How about this? > > Nicolin The new imx7 release have two new codec wm8958 and wm8960. So we have two machine driver imx-wm8960 and imx-wm8958 which should be upstreamed. I am appreciate that you can help me merge the imx-wm8960 to fsl-asoc-card. And i will focus on wm8960 and wm8958 driver. And i will try to merge imx-wm8958 to fsl-asoc-card. Best Regards, Zidan Wang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/