Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754936AbbFLIQT (ORCPT ); Fri, 12 Jun 2015 04:16:19 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:32814 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751957AbbFLIQI (ORCPT ); Fri, 12 Jun 2015 04:16:08 -0400 Date: Fri, 12 Jun 2015 10:16:03 +0200 From: Ingo Molnar To: Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mml@vger.kernel.org, Andy Lutomirski , Denys Vlasenko , Brian Gerst , Peter Zijlstra , Borislav Petkov , "H. Peter Anvin" , Linus Torvalds , Oleg Nesterov , Thomas Gleixner , Waiman Long Subject: Re: [PATCH 05/12] mm: Introduce arch_pgd_init_late() Message-ID: <20150612081603.GA13868@gmail.com> References: <1434031637-9091-1-git-send-email-mingo@kernel.org> <1434031637-9091-6-git-send-email-mingo@kernel.org> <20150611112349.e63bf0d2116c583e51c7e881@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150611112349.e63bf0d2116c583e51c7e881@linux-foundation.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 39 * Andrew Morton wrote: > On Thu, 11 Jun 2015 16:07:10 +0200 Ingo Molnar wrote: > > > --- a/kernel/fork.c > > +++ b/kernel/fork.c > > @@ -1592,6 +1592,22 @@ static struct task_struct *copy_process(unsigned long clone_flags, > > syscall_tracepoint_update(p); > > write_unlock_irq(&tasklist_lock); > > > > + /* > > + * If we have a new PGD then initialize it: > > + * > > + * This method is called after a task has been made visible > > + * on the task list already. > > + * > > + * Architectures that manage per task kernel pagetables > > + * might use this callback to initialize them after they > > + * are already visible to new updates. > > + * > > + * NOTE: any user-space parts of the PGD are already initialized > > + * and must not be clobbered. > > + */ > > + if (p->mm != current->mm) > > + arch_pgd_init_late(p->mm, p->mm->pgd); > > Couldn't this be arch_pgd_init_late(p->mm) or arch_pgd_init_late(p)? Indeed - fixed. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/