Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751070AbbFLIY6 (ORCPT ); Fri, 12 Jun 2015 04:24:58 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:48850 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750732AbbFLIYx (ORCPT ); Fri, 12 Jun 2015 04:24:53 -0400 X-Listener-Flag: 11101 Message-ID: <1434097488.29733.0.camel@mtksdaap41> Subject: Re: [alsa-devel] [PATCH 1/3] ASoC: mediatek: Add AFE platform driver From: Koro Chen To: Paul Bolle CC: , , , , , , , , , , , , Date: Fri, 12 Jun 2015 16:24:48 +0800 In-Reply-To: <1434094677.2271.125.camel@x220> References: <1433946276-25969-1-git-send-email-koro.chen@mediatek.com> <1433946276-25969-2-git-send-email-koro.chen@mediatek.com> <1434006187.24094.40.camel@x220> <1434074158.10969.5.camel@mtksdaap41> <1434094677.2271.125.camel@x220> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 33 On Fri, 2015-06-12 at 09:37 +0200, Paul Bolle wrote: > On Fri, 2015-06-12 at 09:55 +0800, Koro Chen wrote: > > On Thu, 2015-06-11 at 09:03 +0200, Paul Bolle wrote: > > > (What does negating a bool twice do?) > > > > > Because bool actually can be unsigned char, although actually in this > > driver, the caller always passes "true" or "false" to this function. > > bool is _Bool in the kernel (see include/linux/types.h). So whenever you > see a bool in the kernel you can assume it's either 0 or 1. Are there > any cases where this conveniently simple rule doesn't hold? > > But here the discussion is moot, because as you say, the function will > only be passed false or true so we know "enable" is either 0 or 1 and > double negating will do nothing. > > > Do you think if this is the case, should I still need to do !!? > > So you should not, as it's confusing at best. > OK, thank you. I will drop it in the next version of patch. > Thanks, > > > Paul Bolle > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/