Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753439AbbFLI4Q (ORCPT ); Fri, 12 Jun 2015 04:56:16 -0400 Received: from mail113-251.mail.alibaba.com ([205.204.113.251]:44658 "EHLO us-alimail-mta1.hst.scl.en.alidc.net" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750732AbbFLI4L (ORCPT ); Fri, 12 Jun 2015 04:56:11 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R671e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=r46d02006;MF=hillf.zj@alibaba-inc.com;PH=DS;RN=6;RT=6;SR=0; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "Mel Gorman" Cc: , "linux-kernel" , "Rik van Riel" , "Johannes Weiner" , "Michal Hocko" Subject: Re: [PATCH 19/25] mm, vmscan: Account in vmstat for pages skipped during reclaim Date: Fri, 12 Jun 2015 16:49:44 +0800 Message-ID: <00f801d0a4ec$bb61a480$3224ed80$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AdCk7GNov+pqob1yQYKRhr8ObZwhSg== Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1022 Lines: 30 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1326,6 +1326,7 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, > > for (scan = 0; scan < nr_to_scan && !list_empty(src); scan++) { > struct page *page; > + struct zone *zone; > int nr_pages; > > page = lru_to_page(src); > @@ -1333,8 +1334,11 @@ static unsigned long isolate_lru_pages(unsigned long nr_to_scan, > > VM_BUG_ON_PAGE(!PageLRU(page), page); > > - if (page_zone_id(page) > sc->reclaim_idx) > + zone = page_zone(page); > + if (page_zone_id(page) > sc->reclaim_idx) { > list_move(&page->lru, &pages_skipped); > + __count_zone_vm_events(PGSCAN_SKIP, page_zone(page), 1); > + } The newly added zone is not used. > > switch (__isolate_lru_page(page, mode)) { > case 0: -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/