Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752786AbbFLJa2 (ORCPT ); Fri, 12 Jun 2015 05:30:28 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:61954 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750866AbbFLJaW (ORCPT ); Fri, 12 Jun 2015 05:30:22 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-93-557aa6aaaa10 Message-id: <557AA6A8.2060106@samsung.com> Date: Fri, 12 Jun 2015 18:30:16 +0900 From: Krzysztof Kozlowski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-version: 1.0 To: Rob Herring , Russell King , linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org, arm@kernel.org, Sekhar Nori , Kevin Hilman , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Hans Ulli Kroll , Shawn Guo , Sascha Hauer , Imre Kaloz , Krzysztof Halasa , Greg Ungerer , Roland Stigge , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Simtec Linux Team , Kukjin Kim , Wan ZongShun , linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 01/15] ARM: kill off set_irq_flags usage References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-2-git-send-email-robh@kernel.org> In-reply-to: <1433874401-27161-2-git-send-email-robh@kernel.org> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUhTYRTHe+69u7vOVrf59qCiNLBMyFyFPtRIi6JLREQkRQg59TpNnbKp 5D6USykrRUtNm04Tp8YQlbnC16x9sKzMl5X2olboQjQ1301by2mR337n/H/nnC+HwgXThCsV LUtk5TJJrJDkEa9+P3+3W1epDPab/OiMugaNOGqfM5DommWMQEZTEYb01ycA6q4JQCqtiUDj oyJU0fEIIF1+I4Gyh8dxNGkZAGjgIY70w30cZGoqJlGRNptAhV1PMPTJxEcrj1UEMhdcQW1Z dRhSf3dA1pYGLpr6eRiZa7Q4ytV2clDb2xNocfgbFuTOFOc3AyY9LZNkFubvEkz/mBVjRvQ9 gMmumeUwjepBLmPOyeUyet1Nkkl92kUwA30tJFOvvco0NsxijKE8ism2+DHmL6XEaecLPHEE GxudzMr3HArlRX3Nr8QSMj0u96n6sFSw7HwL2FGQ3g8LyxewdXaG3UO15C3AowR0BYDVN27j 64UZwHsZ82sWn/aBpomXuI0J2gu2avKAjUl6H6yv0pI2dqLPwwlTx19/G1zKHSJs7EgnwIqq Vq5tKU6nceGPO8tcW+BAi+HSyoc1SUAnwVFdFsfGdnQQfN39ZpWp1QFf+LnHx9bGaU9YXz2B 5wBaveGE+r+l3mA9ALgOOLFJ4QmKMGmcyFchiVMkyaS+4fFxerD+CHMNoLz9gBHQFBBu5vO8 lcECjiRZkRJnBJDChY78Fu1qix8hSVGy8viL8qRYVmEEbhQhdOFrmqbOCmipJJGNYdkEVv4v xSg711QgSbW6GNxjc9s7VLUGsOVMYM80FrkpLKDV3ynwqKbZc0RGu4U8m7eEHCzZeXLrixlv qYktLfjVe0ossp8pLGyyO1dn9SLtHfgt22s1Vf5l/emysuOs4JK/xVPJomMZHvbBodLO++L3 iyU53GR5/45IXUyve57Fd9feI8vdllAhoYiSiHxwuULyB+3oVLkEAwAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4012 Lines: 90 On 10.06.2015 03:26, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Russell King > Cc: Sekhar Nori > Cc: Kevin Hilman > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Sebastian Hesselbarth > Cc: Gregory Clement > Cc: Hans Ulli Kroll > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Imre Kaloz > Cc: Krzysztof Halasa > Cc: Greg Ungerer > Cc: Roland Stigge > Cc: Tony Lindgren > Cc: Daniel Mack > Cc: Haojian Zhuang > Cc: Robert Jarzmik > Cc: Simtec Linux Team > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Wan ZongShun > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-omap@vger.kernel.org > Cc: linux-samsung-soc@vger.kernel.org > --- > arch/arm/common/it8152.c | 2 +- > arch/arm/common/locomo.c | 2 +- > arch/arm/common/sa1111.c | 4 ++-- > arch/arm/mach-davinci/cp_intc.c | 2 +- > arch/arm/mach-dove/irq.c | 2 +- > arch/arm/mach-ebsa110/core.c | 2 +- > arch/arm/mach-footbridge/common.c | 2 +- > arch/arm/mach-footbridge/isa-irq.c | 8 ++++---- > arch/arm/mach-gemini/gpio.c | 2 +- > arch/arm/mach-gemini/irq.c | 2 +- > arch/arm/mach-imx/3ds_debugboard.c | 2 +- > arch/arm/mach-imx/mach-mx31ads.c | 2 +- > arch/arm/mach-iop13xx/irq.c | 2 +- > arch/arm/mach-iop32x/irq.c | 2 +- > arch/arm/mach-iop33x/irq.c | 2 +- > arch/arm/mach-ixp4xx/common.c | 2 +- > arch/arm/mach-ks8695/irq.c | 2 +- > arch/arm/mach-lpc32xx/irq.c | 2 +- > arch/arm/mach-netx/generic.c | 2 +- > arch/arm/mach-omap1/fpga.c | 2 +- > arch/arm/mach-omap1/irq.c | 2 +- > arch/arm/mach-pxa/balloon3.c | 2 +- > arch/arm/mach-pxa/irq.c | 1 - > arch/arm/mach-pxa/lpd270.c | 2 +- > arch/arm/mach-pxa/pcm990-baseboard.c | 2 +- > arch/arm/mach-pxa/pxa3xx.c | 2 +- > arch/arm/mach-pxa/viper.c | 2 +- > arch/arm/mach-pxa/zeus.c | 2 +- > arch/arm/mach-rpc/ecard.c | 2 +- > arch/arm/mach-rpc/irq.c | 16 ++++++++-------- > arch/arm/mach-s3c24xx/bast-irq.c | 2 +- > arch/arm/mach-s3c64xx/common.c | 2 +- > arch/arm/mach-sa1100/irq.c | 1 - > arch/arm/mach-sa1100/neponset.c | 4 ++-- > arch/arm/mach-w90x900/irq.c | 2 +- > 35 files changed, 45 insertions(+), 47 deletions(-) For the s3c24xx and s3c64xx it looks fine: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/