Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754810AbbFLJpc (ORCPT ); Fri, 12 Jun 2015 05:45:32 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:35717 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754625AbbFLJp1 convert rfc822-to-8bit (ORCPT ); Fri, 12 Jun 2015 05:45:27 -0400 Date: Fri, 12 Jun 2015 12:45:23 +0300 From: Mihai =?UTF-8?B?RG9uyJt1?= To: Takashi Iwai Cc: Jonathan McDowell , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: Audio crackles with 4.1-rc1 Message-ID: <20150612124523.37fd0875@mdontu-l> In-Reply-To: References: <20150430150131.GA10148@earth.li> <20150502150513.GF10148@earth.li> <20150519161911.GD28070@earth.li> <20150519215310.GF28070@earth.li> <20150610131755.0b906783@mdontu-l.dsd.bitdefender.biz> <20150610134135.327e2bdc@mdontu-l.dsd.bitdefender.biz> <20150610144551.4578ee99@mdontu-l.dsd.bitdefender.biz> <20150610192202.0e987fd0@mdontu-l.dsd.bitdefender.biz> <20150610194303.3b82609d@mdontu-l.dsd.bitdefender.biz> <20150611011236.53bcd1fd@mdontu-l> <20150612012318.6e3482ed@mdontu-l> Organization: Home MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2963 Lines: 75 On Fri, 12 Jun 2015 09:00:06 +0200 Takashi Iwai wrote: > At Fri, 12 Jun 2015 01:23:18 +0300, Mihai Donțu wrote: > > No, 4.0.5 and all previous kernels (>= 3.12) are OK. I have attached a > > small tarball with the two files produced by alsa-info.sh. > > Both are taken in different states (one is headphone plugged and > another unplugged?). At best, take the snapshot in the same situation > for comparison. > > In anyway, below is another shot in dark. The white noise is possibly > the ill side effect of analog loopback. But it's strange that this > didn't happen on 4.0.x. And, it combines another black magic that > worked for another Dell model. Let's see. > > > Takashi > > --- > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index 9d3e0fcb4326..cf46f6012ba4 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -4522,6 +4522,8 @@ enum { > ALC288_FIXUP_DELL1_MIC_NO_PRESENCE, > ALC288_FIXUP_DELL_XPS_13_GPIO6, > ALC298_FIXUP_DELL1_MIC_NO_PRESENCE, > + ALC292_FIXUP_DELL_E74, > + ALC292_FIXUP_DISABLE_AAMIX, > }; > > static const struct hda_fixup alc269_fixups[] = { > @@ -5054,6 +5056,16 @@ static const struct hda_fixup alc269_fixups[] = { > .chained = true, > .chain_id = ALC269_FIXUP_HEADSET_MODE > }, > + [ALC292_FIXUP_DISABLE_AAMIX] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_disable_aamix, > + }, > + [ALC292_FIXUP_DELL_E74] = { > + .type = HDA_FIXUP_FUNC, > + .v.func = alc_fixup_dell_xps13, > + .chained = true, > + .chain_id = ALC292_FIXUP_DISABLE_AAMIX > + }, > }; > > static const struct snd_pci_quirk alc269_fixup_tbl[] = { > @@ -5066,6 +5078,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1025, 0x0775, "Acer Aspire E1-572", ALC271_FIXUP_HP_GATE_MIC_JACK_E1_572), > SND_PCI_QUIRK(0x1025, 0x079b, "Acer Aspire V5-573G", ALC282_FIXUP_ASPIRE_V5_PINS), > SND_PCI_QUIRK(0x1028, 0x0470, "Dell M101z", ALC269_FIXUP_DELL_M101Z), > + SND_PCI_QUIRK(0x1028, 0x05cb, "Dell Latitude E7440", ALC292_FIXUP_DELL_E74), > SND_PCI_QUIRK(0x1028, 0x05da, "Dell Vostro 5460", ALC290_FIXUP_SUBWOOFER), > SND_PCI_QUIRK(0x1028, 0x05f4, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), > SND_PCI_QUIRK(0x1028, 0x05f5, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE), Nice shot! It appears to work. :-) No clicks, no static. I had to apply it by hand over 4.1-rc7, because the first two arrays look different in both it and -master. Anyway, I will play with it some more today see if anything else is broken. Oh, and yes, the second state is without headphones on. I removed them without thinking when the noise started. Sorry about that. Thanks! -- Mihai Donțu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/