Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754461AbbFLKJA (ORCPT ); Fri, 12 Jun 2015 06:09:00 -0400 Received: from mail-oi0-f50.google.com ([209.85.218.50]:36747 "EHLO mail-oi0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752136AbbFLKI6 (ORCPT ); Fri, 12 Jun 2015 06:08:58 -0400 MIME-Version: 1.0 In-Reply-To: <20150612092103.GB18158@patagonia> References: <1434092837-10290-1-git-send-email-juston.h.li@gmail.com> <20150612092103.GB18158@patagonia> Date: Fri, 12 Jun 2015 03:08:57 -0700 X-Google-Sender-Auth: SgrCTMqbBFe6wTZjQ1tEn_-qH7Q Message-ID: Subject: Re: [PATCH] staging: sm750fb: fix c99 comments From: Juston Li To: Konrad Zapalowicz Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com, gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1038 Lines: 28 On Fri, Jun 12, 2015 at 2:21 AM, Konrad Zapalowicz wrote: >> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c >> index 8b47c1b..b2137c8 100644 >> --- a/drivers/staging/sm750fb/ddk750_chip.c >> +++ b/drivers/staging/sm750fb/ddk750_chip.c >> @@ -17,7 +17,7 @@ logical_chip_type_t getChipType(void) >> char physicalRev; >> logical_chip_type_t chip; >> >> - physicalID = devId750;//either 0x718 or 0x750 >> + physicalID = devId750; /* either 0x718 or 0x750 / > > Does the code compile? I'm worried that the above line will produce > error as the comment block is not properly closed. > > - konrad Good catch, can't believe I missed that. I'll fix, actually test compile this time and resend. Regards Juston -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/