Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754974AbbFLMiz (ORCPT ); Fri, 12 Jun 2015 08:38:55 -0400 Received: from demumfd001.nsn-inter.net ([93.183.12.32]:41599 "EHLO demumfd001.nsn-inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753438AbbFLMix (ORCPT ); Fri, 12 Jun 2015 08:38:53 -0400 Message-ID: <557AD2D5.2060102@nokia.com> Date: Fri, 12 Jun 2015 14:38:45 +0200 From: Alexander Sverdlin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: ext Nicholas Mc Guire , Wolfram Sang CC: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: octeon: remove unused signal handling References: <1434031923-20914-1-git-send-email-hofrat@osadl.org> In-Reply-To: <1434031923-20914-1-git-send-email-hofrat@osadl.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-size: 1860 X-purgate-ID: 151667::1434112726-00006B28-30AA220E/0/0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2047 Lines: 63 Hi! On 11/06/15 16:12, ext Nicholas Mc Guire wrote: > 'commit 2637e5fd232d ("i2c: octeon: Fix i2c fail problem when a process is > terminated by a signal")' removed the wait_event_interruptible_timeout to > prevent half/mixed i2c messages from being sent/recievd but forgot to > drop the signal handling case in the return handling. This just removes > this dead code. While at it the return variable is adjusted to the type > expected. > > Signed-off-by: Nicholas Mc Guire Looks good, Reviewed-by: Alexander Sverdlin > --- > > V2: Thanks to Wolfram Sang for clarifying the intent > (and how I should have found this by properly checking the git log). > > Patch was compile tested with cavium_octeon_defconfig > (implies CONFIG_I2C_OCTEON=y) > > Patch is against 4.1-rc7 (localversion-next is -next-20150611) > > drivers/i2c/busses/i2c-octeon.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-octeon.c b/drivers/i2c/busses/i2c-octeon.c > index 6e75e01..32914ab 100644 > --- a/drivers/i2c/busses/i2c-octeon.c > +++ b/drivers/i2c/busses/i2c-octeon.c > @@ -200,7 +200,7 @@ static int octeon_i2c_test_iflg(struct octeon_i2c *i2c) > */ > static int octeon_i2c_wait(struct octeon_i2c *i2c) > { > - int result; > + long result; > > octeon_i2c_int_enable(i2c); > > @@ -210,10 +210,7 @@ static int octeon_i2c_wait(struct octeon_i2c *i2c) > > octeon_i2c_int_disable(i2c); > > - if (result < 0) { > - dev_dbg(i2c->dev, "%s: wait interrupted\n", __func__); > - return result; > - } else if (result == 0) { > + if (result == 0) { > dev_dbg(i2c->dev, "%s: timeout\n", __func__); > return -ETIMEDOUT; > } -- Best regards, Alexander Sverdlin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/