Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755231AbbFLM74 (ORCPT ); Fri, 12 Jun 2015 08:59:56 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:34390 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755011AbbFLM7v (ORCPT ); Fri, 12 Jun 2015 08:59:51 -0400 Date: Fri, 12 Jun 2015 14:59:41 +0200 From: Peter Zijlstra To: Frederic Weisbecker Cc: LKML , Thomas Gleixner , Preeti U Murthy , Christoph Lameter , Ingo Molnar , Viresh Kumar , Rik van Riel Subject: Re: [PATCH 5/8] nohz: Restart the tick from irq exit Message-ID: <20150612125941.GX19282@twins.programming.kicks-ass.net> References: <1434044168-23173-1-git-send-email-fweisbec@gmail.com> <1434044168-23173-6-git-send-email-fweisbec@gmail.com> <20150612073245.GO3644@twins.programming.kicks-ass.net> <20150612123835.GA29736@lerouge> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150612123835.GA29736@lerouge> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 21 On Fri, Jun 12, 2015 at 02:38:36PM +0200, Frederic Weisbecker wrote: > On Fri, Jun 12, 2015 at 09:32:45AM +0200, Peter Zijlstra wrote: > > On Thu, Jun 11, 2015 at 07:36:05PM +0200, Frederic Weisbecker wrote: > > > Restart the tick when necessary from the irq exit path. It makes nohz > > > full more flexible and allow it to piggyback the tick restart on the > > > scheduler IPI in the future instead of sending a dedicated IPI that > > > often doubles the scheduler IPI on task wakeup. This will require > > > careful review of resched_curr() callers. > > > > This seems to assume schedule_ipi() callers use irq_exit(), this is > > false. > > Indeed there will be that too. Note the current patch doesn't yet rely on > schedule_ipi(), we are still using the nohz ipis. Ah, then I just didn't understand your changelog right. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/