Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755289AbbFLNab (ORCPT ); Fri, 12 Jun 2015 09:30:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47708 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755209AbbFLNa2 (ORCPT ); Fri, 12 Jun 2015 09:30:28 -0400 Date: Fri, 12 Jun 2015 09:30:26 -0400 From: Aristeu Rozanski To: lukasz.anaczkowski@intel.com Cc: mchehab@osg.samsung.com, dougthompson@xmission.com, bp@alien8.de, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Jim Snow Subject: Re: [PATCH 2/3] sb_edac: virtualize several hard-coded functions Message-ID: <20150612133025.GG14408@redhat.com> References: <1433850192-9866-1-git-send-email-lukasz.anaczkowski@intel.com> <1433850192-9866-3-git-send-email-lukasz.anaczkowski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1433850192-9866-3-git-send-email-lukasz.anaczkowski@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1076 Lines: 32 Hi Jim, Lukasz, On Tue, Jun 09, 2015 at 01:43:11PM +0200, lukasz.anaczkowski@intel.com wrote: > @@ -273,6 +270,10 @@ struct sbridge_info { > u64 (*get_tolm)(struct sbridge_pvt *pvt); > u64 (*get_tohm)(struct sbridge_pvt *pvt); > u64 (*rir_limit)(u32 reg); > + u64 (*sad_limit)(u32 reg); > + u32 (*interleave_mode)(u32 reg); > + char* (*show_interleave_mode)(u32 reg); > + u32 (*dram_attr)(u32 reg); > const u32 *dram_rule; > const u32 *interleave_list; > const struct interleave_pkg *interleave_pkg; the only reason these exist is for when there's a difference between memory controllers: > pvt->info.get_memory_type = get_memory_type; > pvt->info.get_memory_type = get_memory_type; > pvt->info.get_memory_type = haswell_get_memory_type; until then such change isn't really necessary. -- Aristeu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/