Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755408AbbFLOf5 (ORCPT ); Fri, 12 Jun 2015 10:35:57 -0400 Received: from mail-vn0-f50.google.com ([209.85.216.50]:42247 "EHLO mail-vn0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbbFLOfz (ORCPT ); Fri, 12 Jun 2015 10:35:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-2-git-send-email-robh@kernel.org> From: Rob Herring Date: Fri, 12 Jun 2015 09:35:33 -0500 X-Google-Sender-Auth: R-kS9OTgU3p-iYhaDt4ujFUsAo8 Message-ID: Subject: Re: [PATCH 01/15] ARM: kill off set_irq_flags usage To: Hans Ulli Kroll Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Sekhar Nori , Kevin Hilman , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Shawn Guo , Sascha Hauer , Imre Kaloz , Krzysztof Halasa , Greg Ungerer , Roland Stigge , Tony Lindgren , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Simtec Linux Team , Kukjin Kim , Krzysztof Kozlowski , Wan ZongShun , linux-omap , "linux-samsung-soc@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 33 On Fri, Jun 12, 2015 at 9:05 AM, Hans Ulli Kroll wrote: > > > On Tue, 9 Jun 2015, Rob Herring wrote: > >> set_irq_flags is ARM specific with custom flags which have genirq >> equivalents. Convert drivers to use the genirq interfaces directly, so we >> can kill off set_irq_flags. The translation of flags is as follows: >> >> IRQF_VALID -> !IRQ_NOREQUEST >> IRQF_PROBE -> !IRQ_NOPROBE >> IRQF_NOAUTOEN -> IRQ_NOAUTOEN >> >> For IRQs managed by an irqdomain, the irqdomain core code handles clearing >> and setting IRQ_NOREQUEST already, so there is no need to do this in >> .map() functions and we can simply remove the set_irq_flags calls. Some >> users also set IRQ_NOPROBE and this has been maintained although it is not >> clear that is really needed. There appears to be a great deal of blind >> copy and paste of this code. >> > > for mach-gemini > Signed-off-by: Hans Ulli Kroll You mean acked-by, right? Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/